Change add client response and correct area ids#5
Merged
DocMoebiuz merged 1 commit intoMobiFlight:mainfrom Apr 3, 2022
Merged
Conversation
Contributor
|
That is great. The client does not need to know the WASM internal used IDs |
Collaborator
Author
|
Hi yes, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify response when adding a new client. The client does not need to know the WASM internal used IDs for the ClientDataAreas.
Old Response:
{"Name": "MyGreatClient", "SimVars": 3, "Command": 4, "Response": 5}
New Response:
MF.Clients.Add.MyGreatClient.Finished
Change default DataAreaIDs for Mobiflight ClientDataAreas back to the original values. (In the end it doesn't matter, the IDs don't need to be the same on WASM and on external SimConnect client side).
Now in the PR:
SimVar = 0
Command = 1 (SimVar+1)
Response = 2 (Command+1)
Before it was by mistake:
SimVar = 0
Command = 2
Response = 1
Attached debug wasm
MobiFlightWasmModule.zip
.