Skip to content

fix(ci): pass publish secrets explicitly to mbl-actionhub - #37

Merged
therajanmaurya merged 2 commits into
developmentfrom
fix/publish-secrets
Apr 28, 2026
Merged

fix(ci): pass publish secrets explicitly to mbl-actionhub#37
therajanmaurya merged 2 commits into
developmentfrom
fix/publish-secrets

Conversation

@therajanmaurya

@therajanmaurya therajanmaurya commented Apr 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • secrets: inherit fails to resolve required: true secrets when calling a reusable workflow in a different repository
  • Pass each secret explicitly instead: MAVEN_CENTRAL_USERNAME, MAVEN_CENTRAL_PASSWORD, SIGNING_KEY_ID, GPG_KEY_CONTENTS, SIGNING_PASSWORD

Root cause

GitHub Actions error: "Secret MAVEN_CENTRAL_USERNAME is required, but not provided while calling"secrets: inherit is unreliable for cross-repo reusable workflows with required secrets.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Enhanced security controls for the publishing workflow by restricting credential access to only necessary permissions.

secrets: inherit fails for required secrets in cross-repo reusable
workflows — pass each secret explicitly instead.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Apr 28, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2a94399b-debb-4bdd-8378-026899687c36

📥 Commits

Reviewing files that changed from the base of the PR and between dc4ec49 and bb10a00.

📒 Files selected for processing (1)
  • .github/workflows/publish.yml

📝 Walkthrough

Walkthrough

The publish workflow job's secret propagation strategy is updated from implicit inheritance to explicit mapping. Only Maven Central and GPG-related secrets are forwarded to the MobileByteLabs/mbl-actionhub reusable workflow, replacing the blanket secrets: inherit approach.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Configuration
.github/workflows/publish.yml
Changed secret propagation from secrets: inherit to explicit secrets mapping, forwarding only Maven Central and signing/GPG-related secrets to the reusable workflow invocation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A rabbit hops through actions grand,
Secrets now in careful hand,
No more inherited with haste,
Only what's truly needed, placed with taste!
Security springs from explicit care. 🔐✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: switching from inherited secrets to explicit secret passing in the CI workflow for the mbl-actionhub reusable workflow invocation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/publish-secrets

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

The actual failure was missing repo secrets, not secrets: inherit.
Explicit secret passing was wrong fix — revert to match KmpToolkit.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@therajanmaurya
therajanmaurya merged commit a7add63 into development Apr 28, 2026
7 checks passed
@mobilebytesenseicommunity
mobilebytesenseicommunity deleted the fix/publish-secrets branch June 17, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant