Skip to content

Fire off kotlin 1.5 compatible snapshot#273

Merged
digitalbuddha merged 2 commits intomainfrom
miken/15breakingchange
May 10, 2021
Merged

Fire off kotlin 1.5 compatible snapshot#273
digitalbuddha merged 2 commits intomainfrom
miken/15breakingchange

Conversation

@digitalbuddha
Copy link
Contributor

  • Upgrade to kotlin 1.5
  • fix Jacoco compat issue
  • change snapshot version to 4.0.2-KT15-SNAPSHOT (will auto release post merge)
    • validate all tests pass, update api checks (1.5 changed functions)

fixes #263 which had crashes due to kotlin 1.5 duration class type changes.

We will try to release 1.4 compatible and 1.5 compatible changes for next few months. We will eventually stop supporting 1.4 and instead release only 1.5 compatible versions.

@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #273 (542029a) into main (e2c5cbf) will increase coverage by 2.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #273      +/-   ##
============================================
+ Coverage     83.00%   85.33%   +2.33%     
+ Complexity      182      179       -3     
============================================
  Files            48       49       +1     
  Lines           859      914      +55     
  Branches        129      126       -3     
============================================
+ Hits            713      780      +67     
+ Misses           80       77       -3     
+ Partials         66       57       -9     
Impacted Files Coverage Δ Complexity Δ
.../android/external/fs3/filesystem/FileSystemImpl.kt 95.12% <100.00%> (ø) 17.00 <0.00> (+1.00)
...m/dropbox/android/external/store4/StoreDefaults.kt 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
.../dropbox/android/external/store4/impl/RealStore.kt 92.53% <100.00%> (+1.91%) 16.00 <0.00> (ø)
...android/external/store4/impl/RefCountedResource.kt 88.00% <0.00%> (-3.31%) 6.00% <0.00%> (-1.00%)
...in/kotlin/com/dropbox/store/rx2/RxSourceOfTruth.kt 68.18% <0.00%> (-1.82%) 0.00% <0.00%> (ø%)
...in/kotlin/com/dropbox/store/rx3/RxSourceOfTruth.kt 68.18% <0.00%> (-1.82%) 0.00% <0.00%> (ø%)
...main/java/com/dropbox/android/external/fs3/Util.kt 69.23% <0.00%> (-1.14%) 16.00% <0.00%> (-1.00%)
...ava/com/dropbox/android/external/store4/Fetcher.kt 100.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
.../java/com/dropbox/android/external/fs3/FSWriter.kt 100.00% <0.00%> (ø) 3.00% <0.00%> (ø%)
...om/dropbox/android/external/store4/MemoryPolicy.kt 87.50% <0.00%> (ø) 16.00% <0.00%> (+4.00%)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2c5cbf...542029a. Read the comment docs.

@digitalbuddha digitalbuddha merged commit 86ab7a5 into main May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Crash in Store 4.0 with Kotlin 1.5.0-RC

2 participants