Generate the TNumber value splits#82
Merged
estebanzimanyi merged 1 commit intoJul 23, 2026
Merged
Conversation
The value split and value-time split of tint and tfloat return the temporal fragments alongside a per-fragment value-bin out-parameter (and, for the value-time split, a parallel time-bin out-parameter), the same split shape as the time split with the bin dimension carrying a base value rather than a timestamp. Add the value bin dimension to the split-key map: an int bin array reads the number component through getInt, a double bin array through getDouble. The split fold already walks its bin dimensions in order, so the one-dimensional value split and the two-dimensional value-time split both fold into records — (number, fragment) and (number, time, fragment) — with no further change. A parity test checks the int value split and the float value-time split against direct GeneratedFunctions calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value split and value-time split of tint and tfloat return the temporal fragments alongside a per-fragment value-bin out-parameter (and, for the value-time split, a parallel time-bin out-parameter) — the same split shape as the time split, with the bin dimension carrying a base value rather than a timestamp.
This adds the value bin dimension to the split-key map: an
intbin array reads thenumbercomponent throughgetInt, adoublebin array throughgetDouble. The split fold already walks its bin dimensions in order, so the one-dimensional value split and the two-dimensional value-time split both fold into records —(number, fragment)and(number, time, fragment)— with no further change.A parity test checks the int value split and the float value-time split against direct
GeneratedFunctionscalls.