Name a temporal property's type as the standard defines it - #56
Merged
Conversation
A TemporalProperty document names its type with one of the five tokens the standard declares — `components/schemas/temporalProperty/properties/type` admits TBoolean, TText, TInteger, TReal and TImage — so an integer property is written TInteger and a boolean one TBoolean, where they read TInt and TBool. The token is the tier's internal name for the type as well, so the aggregation table and the window dispatch carry the same spelling and a stream query over either property resolves as before; the spellings a caller may write when storing a property are unchanged, `tint` and `tbool` among them. A test reads the admitted set out of the vendored schema and checks the token of every spelling the tier accepts, which is what the suite lacked: the plural TemporalProperties document was validated against its schema and the singular one was not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A TemporalProperty document names its type with one of the five tokens the standard declares:
components/schemas/temporalProperty/properties/typeadmits TBoolean, TText, TInteger, TReal and TImage. An integer property is written TInteger and a boolean one TBoolean. The token is the tier's internal name for the type as well, so the aggregation table and the window dispatch carry the same spelling and a stream query over either property resolves through it; the spellings a caller may write when storing a property stay as they are,tintandtboolamong them. A test reads the admitted set out of the vendored schema and checks the token of every spelling the tier accepts, so the singular TemporalProperty document is validated against its schema as the plural TemporalProperties document is.The rest of that schema has two cells no document can satisfy, and both belong to the standard rather than to the tier:
temporalPrimitiveValuedeclaresdatetimesan array ofminItems: 2besidevaluesas a single scalar, and itsinterpolationenum reads Discrete/Step/Linear/Regression where the temporal-geometry half of the same document names Stepwise. The test asserts the cell that has one authority.