test(parity): 050_geo_inventory.test — geo regression files manifest#26
Merged
nhungoc1508 merged 1 commit intomainfrom May 4, 2026
Merged
test(parity): 050_geo_inventory.test — geo regression files manifest#26nhungoc1508 merged 1 commit intomainfrom
nhungoc1508 merged 1 commit intomainfrom
Conversation
Single-file inventory of MobilityDB's mobilitydb/test/geo/queries/ surface. Rather than one parity file per upstream regression file, this lists what each file covers, what's bound in MobilityDuck today, and what's missing. Bound surface (per direct audit of src/geo/tgeompoint.cpp): - tgeompoint / tgeometry I/O for instant / discrete / continuous / sequence-set - asText / asEWKT / memSize / interp / round / transform - Constructors (TGEOMPOINT, tgeompointInst, tgeompointSeq, tgeompointSeqSet) - Spatial accessors: getX/Y/Z, length, cumulativeLength, speed, direction, azimuth, angularDifference, trajectory - Topological predicates: e/a/t variants of Contains, Disjoint, Dwithin, Intersects, Touches - Set ops: makeSimple, isSimple, stops - Restrictions: atGeometry, atStbox, atValues, atTime and the matching minus* - Modification: appendInstant, appendSequence, insert, update, deleteTime, merge - Comparison: temporal_eq / temporal_ne / etc. - twCentroid, shortestLine, distance_gs, collect_gs Unbound surface (per upstream regression file, with cross-references to the temporal-side parity-batch PRs that cover the same gap): - 051_stbox: stbox tests (whole file currently skipped in test/sql/stbox.test for DuckDB 1.4 signature issues). - 052_tgeo / 052_tpoint: mostly bound — per-type ports would mirror PRs #13 / #17 / #18 patterns. - 053_*_inout: asMFJSON / asWKB / asHexWKB / asGeoJSON — verify which are bound. - 054_*_compops: same parser blocker as PR #24's 030 (?= / #=). - 056_*_spatialfuncs: bulk bound; setSRID-on-temporal and reference-system accessors missing. - 058_*_tile: same gap as PR #23's 025 but for tspatial. - 060_*_topops: same pattern as PR #25's 032_temporal_topops. - 062_*_posops: same pattern as PR #24's 034_temporal_posops plus spatial-direction operators. - 064_*_distance: <-> for tgeo / tpoint; partially bound (shortestLine, distance_gs). - 066_tpoint_similarity: specialisation of PR #23's 038. - 068_*_aggfuncs: same architectural blocker as PR #21 (no AggregateFunction infra). Suite: 747 assertions, 23 test cases.
Member
Author
|
Verified against current main: this PR is a documentation manifest of the geo regression files (no queries to refresh). The skip block contains only a placeholder |
estebanzimanyi
force-pushed
the
feat/parity-geo-inventory
branch
from
fbca631 to
b574fc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Single-file inventory of MobilityDB's
mobilitydb/test/geo/queries/surface (18 upstream files: 051_stbox, 052/053/054/056/058/060/062/064/068 paired tgeo+tpoint, 066_tpoint_similarity).Rather than one parity file per upstream regression file (which would add 18 more PRs to the queue), this consolidates into a single readable manifest documenting:
src/geo/tgeompoint.cpp/src/geo/tgeometry.cpp/src/geo/stbox.cpp(substantial — about 80 distinct function names, including all the ever-/transient-/always- spatial predicates, the spatial accessors, restrictions, modifications, and shortest-line / centroid surface).Cross-reference index
054_*_compopsever-/always- ops (?=,#=)030_temporal_compops058_*_tile(table-returning)025_temporal_tile060_*_topopstopological ops on temporal032_temporal_topops062_*_posopsposition ops on temporal034_temporal_posops066_tpoint_similarityFrechet / DTW038_temporal_similarity068_*_aggfuncsaggregates015_span_aggfuncs, #24's040_temporal_aggfuncsTest plan
make releasethenTZ=UTC ./build/release/test/unittest "<proj>/test/*"— full suite passes (747 assertions across 23 test cases).Drafted because the value is the manifest, not the (single token) assertion. With this PR, every upstream regression file across
mobilitydb/test/temporal/queries/andmobilitydb/test/geo/queries/has either a parity port or an inventory entry.