feat(bindings): temporal boxops followups — named-function aliases + tboxes/splitN/splitEachN#72
Closed
estebanzimanyi wants to merge 1 commit intomainfrom
Closed
feat(bindings): temporal boxops followups — named-function aliases + tboxes/splitN/splitEachN#72estebanzimanyi wants to merge 1 commit intomainfrom
estebanzimanyi wants to merge 1 commit intomainfrom
Conversation
…tboxes/splitN/splitEachN
Closes 7 of 8 missing names in temporal/032_temporal_boxops:
Named-function aliases for the existing topological operators
(MobilityDB exposes both forms; the operator versions were already
wired). Each alias routes through the same underlying handler:
- temporal_contains (alias of @>)
- temporal_contained (alias of <@)
- temporal_overlaps (alias of &&)
- temporal_adjacent (alias of -|-)
Coverage spans all 36 existing operator overloads:
- temporal × temporal (every base-type pair)
- temporal × tstzspan and tstzspan × temporal
- tnumber × numspan / numspan × tnumber
- tnumber × tbox / tbox × tnumber
A REG_TOP4 macro factors out the 4-name × 4-handler explosion in the
tnumber × {numspan, tbox} block.
Plus tnumber → LIST(tbox) emitters:
- tboxes(tint|tfloat) -> LIST(tbox)
- splitNTboxes(tint|tfloat, int) -> LIST(tbox)
- splitEachNTboxes(tint|tfloat, int) -> LIST(tbox)
The 8th missing name, `temporal_same` (alias of `~=`), stays in a
follow-up: the underlying ~= operator handlers (Same_*) are not yet
wired in MobilityDuck. Adding them is straightforward MEOS plumbing
but warrants a focused PR.
Test: test/sql/parity/032_temporal_boxops_followups.test (9 assertions).
Full suite: 761 / 14 cases under TZ=UTC.
Files also gain a trailing newline at EOF.
This was referenced Apr 30, 2026
Member
Author
|
Superseded by the consolidated PR branch |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes 7 of 8 missing names in `temporal/032_temporal_boxops` (was 27%; this brings the user-visible surface to ~88%).
New SQL surface
Named-function aliases for the existing topological operators
MobilityDB exposes both the operator and named-function form for each topological predicate. The operator forms (`@>`, `<@`, `&&`, `-|-`) are already wired across all 36 existing overloads; this PR registers the matching named functions against the same handlers.
Coverage:
A small `REG_TOP4` macro factors the tnumber × {numspan, tbox} 4-handler block.
tnumber → LIST(tbox) emitters
What stays unregistered
The 8th missing name, `temporal_same` (alias of `
=`), is deferred. The underlying `=` operator handlers (`Same_temporal_temporal`, `Same_tnumber_numspan`, `Same_tnumber_tbox`, `Same_temporal_tstzspan`) are not yet wired in MobilityDuck. Adding them is straightforward MEOS plumbing — one new handler family + a parallel registration block — but warrants a focused PR rather than expanding the surface of this one.Tests
Coverage delta
Per the audit in PR #66:
Test plan