feat(bindings): temporal_same — closes the topo-predicate gap#80
Closed
estebanzimanyi wants to merge 1 commit intomainfrom
Closed
feat(bindings): temporal_same — closes the topo-predicate gap#80estebanzimanyi wants to merge 1 commit intomainfrom
estebanzimanyi wants to merge 1 commit intomainfrom
Conversation
Adds 7 new Same handlers:
- Same_temporal_temporal
- Same_temporal_tstzspan / Same_tstzspan_temporal
- Same_tnumber_numspan / Same_numspan_tnumber
- Same_tnumber_tbox / Same_tbox_tnumber
Each routes to the matching MEOS export (same_*_*). Registers `~=`
operator and `temporal_same` named alias for all 32 type-pair shapes
parallel to the existing Contains/Contained/Overlaps/Adjacent surface.
Folds the tnumber × {numspan, tbox} block under a REG_TOP5 macro
that emits all 5 topo-op registrations per (L, R, FN_SUFFIX) triple,
replacing 32 hand-written lines with 6 macro invocations.
Closes the `temporal_same` gap deferred from PR #72: at the time, the
underlying Same_* handlers were not wired in MobilityDuck. PR #75 added
Same handlers on the tspatial side; this PR finishes the temporal +
tnumber side.
Test: test/sql/parity/032_temporal_same.test (10 assertions covering
Same on temporal × temporal, temporal × tstzspan (both directions),
tnumber × numspan (both directions), tnumber × tbox (both directions),
and the operator-vs-alias equivalence).
Full suite: 762 / 14 cases under TZ=UTC.
Member
Author
|
Superseded by the consolidated PR branch |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the `temporal_same` gap deferred from PR #72. At the time, the underlying `Same_*` handlers were not wired in MobilityDuck. PR #75 added `Same` handlers on the tspatial side; this PR finishes the temporal + tnumber side.
New handlers (7)
SQL surface
Each handler is registered both as the `~=` operator and the `temporal_same` named alias for 32 type-pair shapes parallel to the existing `Contains` / `Contained` / `Overlaps` / `Adjacent` surface:
A new `REG_TOP5` macro folds the tnumber × {numspan, tbox} block (replacing 32 hand-written lines with 6 macro invocations).
Tests
Coverage delta
Per the audit in PR #66:
Test plan