Staging sync: shared toolbar filtering across data grids#182
Merged
VibhavSetlur merged 2 commits intoModelSEED:stagingfrom May 5, 2026
Merged
Staging sync: shared toolbar filtering across data grids#182VibhavSetlur merged 2 commits intoModelSEED:stagingfrom
VibhavSetlur merged 2 commits intoModelSEED:stagingfrom
Conversation
…del evaluation Introduces a shared `useToolbarGridFiltering` hook to unify DataGrid toolbar filter behavior across client-filtered pages while guarding against Community DataGrid truncation callbacks. Extends biochem/grid filter helpers to honor `logicOperator` (AND/OR) and threads operator awareness into PATRIC local filtering, with dedicated unit coverage validating OR semantics, quick-search behavior, and combined filter evaluation. Co-authored-by: Cursor <cursoragent@cursor.com>
…a grids Migrates genomes, media, jobs, model, and RAST table pages to `useToolbarGridFiltering` so toolbar quick-search and column filters behave consistently in local/grid-backed contexts while preserving pagination reset semantics. Updates `DataControlHeader` quick-search application to tag toolbar-originated updates and keep grid quick-filter state synchronized after server-style apply callbacks. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VibhavSetlur:stagingintoModelSEED:staging.Included commits
6898d17feat(filtering): add reusable toolbar filtering hook with OR-aware model evaluationa0f3b94refactor(toolbar): adopt shared filter hook across user/reference data gridsKey changes
useToolbarGridFilteringhook to centralize quick-search + column-filter behavior.Files touched
lib/hooks/useToolbarGridFiltering.tslib/api/biochem.tscomponents/layout/DataControlHeader.tsxcomponents/build-model/PatricGenomesTable.tsxcomponents/build-model/RastGenomesTable.tsxapp/(reference-data)/genomes/page.tsxapp/(reference-data)/genomes/Annotations/page.tsxapp/(reference-data)/list-media/page.tsxapp/(user-data)/my-jobs/page.tsxapp/(user-data)/my-models/page.tsxapp/(user-data)/myMedia/page.tsxtests/unit/utils/gridFiltering.test.tsValidation
npx tsc --noEmitstaging == origin/staging)Made with Cursor