fix(quantization): round INT8 activations to nearest - #1474
Merged
gushiqiao merged 1 commit intoSep 4, 2026
Conversation
gushiqiao
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The current expression converts the
+0.5or-0.5correction to INT8 before adding it. Both corrections become zero, so the later store truncates every fractional quantization bin toward zero. For a row whose absolute maximum is 1, values+0.5and-0.5consequently map to+63and-63instead of the nearest bins+64and-64.Keeping the correction in floating point until the final conversion restores symmetric round-to-nearest behavior and reduces activation quantization error without changing the scale calculation or kernel interface.
Verification
python test_cases/test_triton_int8_quantization.py -v(1 test passed)ruff check --config pyproject.toml lightx2v/common/ops/mm/triton_kernels.py test_cases/test_triton_int8_quantization.pyruff format --check --config pyproject.toml lightx2v/common/ops/mm/triton_kernels.py test_cases/test_triton_int8_quantization.pypython -m py_compile lightx2v/common/ops/mm/triton_kernels.py test_cases/test_triton_int8_quantization.py