Update proto file and use new lossless error bound - #54
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Apache Arrow Flight tester to use a new "lossless" error bound type and removes retention period configuration parameters, synchronizing with changes from ModelarDB-RS.
- Adds LOSSLESS error bound type to protocol definitions
- Removes retention_period_in_seconds from Configuration messages
- Updates test code to use lossless error bounds instead of absolute
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| protocol.proto | Adds LOSSLESS error bound type and removes retention period configuration |
| protocol_pb2.py | Updates generated Python protobuf code with new serialized protocol definitions |
| protocol_pb2.pyi | Updates Python type stubs to reflect protocol changes |
| common.py | Changes test table creation to use lossless error bounds |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
skejserjensen
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Apache Arrow Flight tester to match the latest changes from https://github.com/ModelarData/ModelarDB-RS.
Note that this PR should not be merged before ModelarData/ModelarDB-RS#350 is merged.