Define RFC-026 Phase B implementation gates#370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Phase A made empty MemWAL enrollment recoverable, but it did not validate the row path. The RC.1 source audit found several load-bearing details that must be designed and tested before implementation:
put_no_waitmay mutate before returning an errorwait_for_flush_draincan miss a completed flush failureshutdown_allcan detach an active handlerAckUnknownis cardinality-safe but can overwrite a newer interleaving valueThe documented B1 profile handles these inside the existing one-live-writer-process boundary without waiting for a new Lance release. Public B2 remains blocked on durable attribution, reclamation/orphan cleanup, strict correction, same-key sequencing/idempotency, and persistent operator controls.
Scope
Documentation and implementation planning only. This PR does not add a WAL row path, public stream API, schema syntax, or format-v8 code.
Validation
cargo test -p omnigraph-engine --locked --test memwal_enrollment_gate -- --nocapture— 15 passed, including the explicit unconfigured-S3 skip pathcargo test -p omnigraph-engine --locked --test lance_surface_guards— 23 passedcargo test -p omnigraph-engine --locked --test forbidden_apis— 16 passedgit diff --checkscripts/check-agents-md.sh— 69 links across 65 docsGreptile Summary
This PR defines the next implementation gates for RFC-026. The main changes are:
Confidence Score: 5/5
This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "docs: unify RFC-026 admission lock domai..." | Re-trigger Greptile
Context used: