Add graph-native firehose ingest seam - #438
Merged
Merged
Conversation
aaltshuler
force-pushed
the
codex/graph-native-stream-ingest
branch
from
August 4, 2026 17:21
ea7f774 to
3726408
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Semantics
Rows are processed in firehose order and are not one atomic graph transaction. Edges may depend on earlier settled nodes; this slice does not buffer a later node as a forward reference.
Validation
RUST_MIN_STACK=16777216 cargo test -p omnigraph-engine --features failpoints --test memwal_stream --locked -- --nocapture— 120 passed, 1 ignoredscripts/check-agents-md.shGreptile Summary
The PR adds graph-native NDJSON streaming ingest across the engine, server, client, CLI, and OpenAPI surfaces while reusing the resident MemWAL fold path.
Confidence Score: 4/5
The PR is not yet safe to merge because an unrelated empty-owner cleanup failure can still abort graph handoff before the required lane is attempted.
The current driver records the unrelated cleanup error more accurately, but
cleanup_failedstill returns from the finite round before processing the required productive candidate, so the previously reported handoff failure remains reachable.Files Needing Attention: crates/omnigraph/src/db/omnigraph/stream_driver.rs
Important Files Changed
Sequence Diagram
sequenceDiagram participant Client participant Server participant Engine participant Driver participant MemWAL participant Manifest Client->>Server: POST graph stream ingest (NDJSON) Server->>Engine: Authorized graph-scoped request loop Rows in request order Engine->>Driver: Settle dependency or resident handoff Driver->>Manifest: Heal and validate authority Engine->>MemWAL: Lazily enroll and append row Driver->>Manifest: Fold settled generation Engine-->>Server: Logical row outcome end Server-->>Client: Ordered redacted outcomesReviews (3): Last reviewed commit: "fix(streaming): close graph ingest drive..." | Re-trigger Greptile
Context used (3)