Seed PE Engineering Career Framework as default roles - #61
Merged
Conversation
Prefill Graduate → Principal (IC) and Lead → CTO (management) with responsibilities, behavioural expectations, and progression links from the PE job-description chart. Empty and demo workspaces load the published framework so people can be assigned immediately. Co-authored-by: Damon <Modsofthenation@users.noreply.github.com>
Co-authored-by: Damon <Modsofthenation@users.noreply.github.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
📝 WalkthroughWalkthroughThe PR adds a typed PE Engineering career framework from Graduate through CTO, seeds it into empty and demo workspaces, assigns the initial engineering manager role, and updates onboarding and documentation text. ChangesPE career framework provisioning
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant WorkspaceInitialization
participant seedDefaultRoleFramework
participant Database
participant RoleAssignment
WorkspaceInitialization->>seedDefaultRoleFramework: Seed default framework
seedDefaultRoleFramework->>Database: Insert framework, version, roles, and expectations
seedDefaultRoleFramework-->>WorkspaceInitialization: Return framework and role IDs
WorkspaceInitialization->>Database: Create optional EM person
WorkspaceInitialization->>RoleAssignment: Assign eng_m1 and eng_m2 progression target
Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prefills the app’s default role catalog from the PE Engineering Job Descriptions & Career Progression Chart so you can assign people without authoring roles first. Roles remain editable and you can still upload/replace frameworks.
What’s seeded
IC track
Management track
Each role includes summary, day-to-day responsibilities, behavioural expectations, and progression requirements, plus
nextrole links (e.g. Senior → Staff or Lead).Wiring
Test plan
pnpm --filter @prm/api test(includes pack integrity tests)pnpm --filter @prm/api typecheckpnpm --filter @prm/ui typecheckSummary by CodeRabbit
New Features
Documentation