Fixed error when re-creating a module. Improved some UI. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Button paddings decreased to make the button small - Paginator buttons made smaller - Space between buttons decreased. - Datatable Header height decreased and color darkened - Datatable row height decreased
…ecked if the module is already exists and showed an error message and skipped directory creating part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running php artisan modular:make-module MODULENAME it shows an error if the MODULENAME already exists.
This PR will solve this error. What I have done - checked if the MODULENAME is already exists, then showed a message and SKIPPED rest of the tasks.
I have decreased padding in AppButton component to make the button a bit smaller. it is looking good now.
Made AppDataTable a bit condensed by decreasing py in AppDataTableRow component. Hope this looks better now.