Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes all per call allocation and async overhead from policy evaluation. Evaluator now caches sorted policies per type, completes synchronously for sync policies, and the pipeline's inner async wrappers are eliminated. Benchmark policies cache their decisions so evaluation scaling cost is effectively zero.
Changes
PolicyDecision singleton (
PolicyDecision.cs)Allow()returnsprivate static readonlyinstance instead ofnew PolicyDecision { IsAllowed = true }Evaluator sync fast path (
MutationPolicyEvaluator.cs)IMutationPolicy<TState>[]per state type viaConcurrentDictionaryregistry query + sort hit once per typeValueTask<PolicyDecision>sync completions wrap result directly, zero Task allocationtask.IsCompletedSuccessfullybeforeawaitsync policies complete viatask.Resultwithout async state machineInvokePolicyAsyncwrapper (merged try/catch inline)EvaluateNoTimeoutAsync/AwaitRemainingAsyncasync fallback only when policy actually suspendsPipeline ValueTask path (
MutationExecutionPipeline.cs)EvaluatePolicyDecisionAsyncreturnsValueTask<PolicyDecision>with sync fast path eliminates inner Task + state machine when evaluator completes synchronouslyAwaitPolicyAndRecordAsynchandles async only caseBenchmark isolation (
PolicyBenchmarkSupport.cs)SyncAllowBenchmarkPolicy/AsyncAllowBenchmarkPolicycachePolicyDecision+Task<PolicyDecision>zero per-evaluation allocationNoOpAuditor+NoOpHistoryStoreremoves audit/history noise from baselineBenchmark Results
Closes
Closes #92