Skip to content
This repository was archived by the owner on Jul 13, 2020. It is now read-only.

Remove site object from System#496

Closed
probins wants to merge 1 commit intoModuleLoader:0.50from
probins:0.50-site
Closed

Remove site object from System#496
probins wants to merge 1 commit intoModuleLoader:0.50from
probins:0.50-site

Conversation

@probins
Copy link
Contributor

@probins probins commented Jun 21, 2016

something like this can be put back in as and when the spec gets around to defining it.

@probins
Copy link
Contributor Author

probins commented Jun 21, 2016

tests are using System.site too. Looks like there's quite a lot of changes needed to the test suite to get it in line with the new spec.

@guybedford
Copy link
Member

Let's remove the sites tests then? Or perhaps move the implementation of sites into a hook in the tests if the tests rely on it too heavily?

@probins
Copy link
Contributor Author

probins commented Jun 22, 2016

the tests are currently using site. for 2 things: in system.normalize.spec.js, and to set babel and traceur locations. As both of these have to be changed anyway (normalize no longer exists, and Babel has to change for Babel 6 - if we decide to go with a special build with only import/export transpile, then package.json will have to be changed to reflect that), I don't see much point in doing anything to the tests atm. ISTM the better approach is to decide first what needs to be done to match the polyfill to the spec and the new environment (such as Babel/Traceur), and to ignore the tests until that's done.

@probins
Copy link
Contributor Author

probins commented Jun 23, 2016

site. is also used by index.js for setting path for Babel/Traceur

@probins
Copy link
Contributor Author

probins commented Jul 1, 2016

might as well close this for the moment as well

@probins probins closed this Jul 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants