This repository was archived by the owner on Jul 13, 2020. It is now read-only.
Limit Travis to master branch#497
Closed
probins wants to merge 1 commit intoModuleLoader:0.50from
probins:0.50-travis
Closed
Limit Travis to master branch#497probins wants to merge 1 commit intoModuleLoader:0.50from probins:0.50-travis
probins wants to merge 1 commit intoModuleLoader:0.50from
probins:0.50-travis
Conversation
Member
|
Thinking about this further, I think we should keep the tests failing... Getting the tests in line is a priority. |
Contributor
Author
|
see my comment at #496 (comment) |
Contributor
Author
|
another approach with the tests is to remove them completely from 0.50 to start with, and then gradually add them back in to test the individual functions. |
Member
|
Certainly a lot of the tests relating to these areas can probably be removed, but the main ES semantic tests and custom loader tests are important to keep around and get working with a new approach to replace sites (perhaps just always testing against a custom TestLoader instance that has its own sites alternative). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think I may be misunderstanding https://docs.travis-ci.com/user/customizing-the-build/#Building-Specific-Branches - depends on whether the branch to ignore is the branch being merged or the branch into which the new branch is being merged. Either way, if we change it to master only, then it should not build any others. As and when we need Travis to run on another branch, we can add it to this whitelist.