Skip to content
This repository was archived by the owner on Jul 13, 2020. It is now read-only.

Limit Travis to master branch#497

Closed
probins wants to merge 1 commit intoModuleLoader:0.50from
probins:0.50-travis
Closed

Limit Travis to master branch#497
probins wants to merge 1 commit intoModuleLoader:0.50from
probins:0.50-travis

Conversation

@probins
Copy link
Contributor

@probins probins commented Jun 21, 2016

I think I may be misunderstanding https://docs.travis-ci.com/user/customizing-the-build/#Building-Specific-Branches - depends on whether the branch to ignore is the branch being merged or the branch into which the new branch is being merged. Either way, if we change it to master only, then it should not build any others. As and when we need Travis to run on another branch, we can add it to this whitelist.

@guybedford
Copy link
Member

Thinking about this further, I think we should keep the tests failing... Getting the tests in line is a priority.

@probins
Copy link
Contributor Author

probins commented Jun 22, 2016

see my comment at #496 (comment)

@probins
Copy link
Contributor Author

probins commented Jun 22, 2016

another approach with the tests is to remove them completely from 0.50 to start with, and then gradually add them back in to test the individual functions.

@guybedford
Copy link
Member

Certainly a lot of the tests relating to these areas can probably be removed, but the main ES semantic tests and custom loader tests are important to keep around and get working with a new approach to replace sites (perhaps just always testing against a custom TestLoader instance that has its own sites alternative).

@probins probins closed this Jun 28, 2016
@probins probins deleted the 0.50-travis branch June 28, 2016 13:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants