Bound RTM Base58/Bech32 address input lengths to mitigate DoS#23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
MAX_BASE58_ADDRESS_LENGTHandMAX_BECH32_ADDRESS_LENGTHconstants and an early length check indecodeBase58Checkto reject excessively long Base58 inputs before performing BigInt arithmetic.addressToScriptto reject overlong addresses before attempting Base58 or Bech32 decoding, leaving valid address handling unchanged.Testing
rtm.jsdiff to confirm only minimal length checks were added arounddecodeBase58CheckandaddressToScript, and no other logic was changed.rtm.jswith Node (require('./rtm.js')) but runtime execution could not be completed in this environment because thebech32dependency is not installed, so full dynamic tests were not run.Codex Task