Skip to content

Bound RTM Base58/Bech32 address input lengths to mitigate DoS #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MoneroOcean merged 1 commit into from
May 29, 2026
Merged

Bound RTM Base58/Bech32 address input lengths to mitigate DoS #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions rtm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,12 @@ function sha256(buffer) {
return crypto.createHash('sha256').update(buffer).digest();
}

const MAX_BASE58_ADDRESS_LENGTH = 128;
const MAX_BECH32_ADDRESS_LENGTH = 128;

function decodeBase58Check(value) {
if (value.length > MAX_BASE58_ADDRESS_LENGTH) throw new Error('Base58 address too long');

let num = 0n;
for (const char of value) {
const index = BASE58_INDEXES.get(char);
Expand All @@ -412,6 +417,7 @@ function decodeBase58Check(value) {
}

function addressToScript(addr) {
if (addr.length > MAX_BECH32_ADDRESS_LENGTH) throw new Error('Invalid address ' + addr);
let decoded;
try {
decoded = decodeBase58Check(addr);
Expand Down
Loading