Record benchmark guard exposure - #113
Merged
Merged
Conversation
Run records now retain model provenance and the guard hook's checks, fires, and matched alternatives. Ruled-out: compute a treatment effect with unknown guard exposure | an old row that never recorded whether the guard reached the run cannot distinguish no treatment from an ignored treatment Limit: legacy JSONL artifacts predate model and guard-exposure fields | their absence remains unknown and is never inferred or backfilled Warn: guard exposure is instrumented in the benchmark hook adapter, not by changing guard scoring | M4 rows remain unexposed and metrics refuses their effect estimate Blast: module Undo: easy Certainty: firm Record-Id: r-exposure52
Brings in the M4 verdict (PR #110) and the retired-runner label fix (PR #111). bench/README.md was the only real conflict: dev added M4's dataset row and the model-provenance note, this branch documents the exposure field. Both kept. Limit: M4's existing rows have no exposure field and must read as unknown, not as not-exposed — backfilling by inference would erase the finding Blast: module Undo: easy Certainty: firm Record-Id: r-expomerge1
The report generator now refuses a treatment effect over rows whose guard exposure is unknown. M4's 112 rows predate the field, so the block replaces p = 0.3117 with the reason it is not computed. Limit: bench/VERDICT-M4.md still cites the Fisher figure; the two disagree until the verdict records why the number was withdrawn from the README Blast: module Undo: easy Certainty: firm Record-Id: r-expreadme1
CommitLore — record lintTrailers: clean — 4 commits in Active constraints for the paths this PR touchesLimits (24)
Ruled out (59)
Warnings (33)
Trailer violations fail this check. Active constraints are informational — they are what the repository already decided, not a verdict on this PR. |
MongLong0214
marked this pull request as ready for review
July 28, 2026 06:07
This was referenced Jul 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
No benchmark data was re-run or backfilled.