MongoEngine v0.18.0?

[wojcikstefan]

Hi @erdenezul & @bagerard! First of all, thank you both for your continued efforts to keep this project running! I really appreciate it and I'm sure so do the users of this package :)

I've been thinking that it might be time for a new release of MongoEngine (v0.18.0?). Before we do that though, I wanted to check in with y'all:

1. Does the cleaned up dev changelog look good?
2. Is there anything we should fix/add/remove before cutting a new release?

   • One thing that caught my eye was that the changelog for v0.17.0 said:

     DEPRECATION: EmbeddedDocument.save & .reload are marked as deprecated and will be removed in a next version of mongoengine Confusing error message when calling EmbeddedDocument.save #1552

     Should we drop these methods before cutting the release then?

3. Since the release includes some breaking changes, should we share some suggestions on how to migrate to the latest version in docs/upgrade.rst?
4. Anything else I'm missing?

[bagerard]

Hi @wojcikstefan, thanks for the nice words, I appreciate.
Fine with me to release 0.18.0

1. Looks good, I just have 1 remark regarding the following sentence:

• BREAKING CHANGE: QuerySet.aggregate now takes limit and skip value into account Fix limit usage in aggregate #2029

I initially documented it as a 'Potential breaking change' but maybe we should just document it as a bugfix, what do you think?

2. yep, let's include that. The sooner we get rid of it the better. There is an open PR from @erdenezul but tests aren't passing
3. IMO there is sufficient information in the changelog, we could duplicate it if you think its needed
4. Maybe we could merge this PR: Add Document inherited members to docs #2040, currently some important public methods from the base class arent displayed in the doc.

Let me know if I can help in any way for this release

[erdenezul]

Pr #1570 is green now.

[wojcikstefan]

Thanks fellas! To sum up, the remaining todo's are:

• Change the wording of the QuerySet.aggregate bugfix (done in 118a998)
• Review and merge EmbeddedDocument should not have save method #1552 #1570
• Review and merge Add Document inherited members to docs #2040
• Move dev changelog entries to a separate "Changes in 0.18.0" section (a6c04f4)
• Bump the VERSION const in mongoengine/__init__.py (f08f749)
• Create a GH release for v0.18.0

[wojcikstefan]

Alright, v0.18.0 is building here: https://travis-ci.org/MongoEngine/mongoengine/builds/544667720

Will close this issue once it deploys to PyPI.

[wojcikstefan]

v0.18.0 is live! https://pypi.org/project/mongoengine/0.18.0/

[bagerard]

Great news, sorry I didn't have time to help with the Todo's for this release