Fix a typo #1813
Merged
Fix a typo #1813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
an -> a
Member
|
Thanks! |
prayashm
added a commit
to prayashm/mongoengine
that referenced
this pull request
Sep 21, 2018
* docs: use explicit register_delete_rule example The previous example of creating bi-directional delete rules was vague since the example defined only one class and the relationship between "Foo" and "Bar" wasn't clear. I added a more explicit example where the relationship between the two classes is explicit. * QuerySet limit function now returns all docs in cursor when 0 is passed * test case for MongoEngine#1602 * Clarify comment in validation example * parse read_preference from conn_host MongoEngine#1665 * use read_preference only pymongo3.x MongoEngine#1665 * run tests only pymongo3 MongoEngine#1565 * read_preference from parse_uri only PYMONGO_3 MongoEngine#1665 * return instead of raising StopIteration * Fixed format string issue in mongoengine error message. * fix - allow url with underscore in domain * Fixed formatting issue * Fix issue MongoEngine#1286 and MongoEngine#844.: when building a query set from filters that reference the same field several times, do not assume each value is a dict * Fix a typo (MongoEngine#1813) an -> a * Fix travis's pypi release trigger * fix pypi trigger * fix changelog * tweak tox.ini to pass tests * +date field * +tests for date field * +changelog * Implemented lazy regex compiling in Field classes to improve 'import mongoengine' performance * fix styling flake8 error from CI * Update connecting.rst My suggest is append the parameter in authentication_source in authentication example, because was included in https://github.com/MongoEngine/mongoengine/pull/590/files * Update signals doc - clarification on EmbeddedDocument Since there is a .save() method on EmbeddedDocument, you could be tempted to attach a pre_save event to an EmbeddedDocument (MongoEngine#1720). This update is an attempt to make this clearer. * Clarify that you should use python 2 when developing on mongoengine MongoEngine#1837 * remove dead code * relates to (MongoEngine#710) - Update gridfs.rst to make it clearer that you should save the Document hosting the GridFSProxy after calling .delete() or .replace() on the GridFSProxy - updated GridFSProxy.__str__ so that it would always print both the filename and the grid_id. This should improve debugging * update related tests * fix BaseList.__iter__ operator (MongoEngine#1305) + minor improvements * Document the attribute of .from_json * Fix .delete doc of **write_concern as suggested by MongoEngine#1779 * Fix index creation error that was swallowed by hasattr under python2 (MongoEngine#1688) * Improve doc of EmbeddedDocumentList.filter and clarify that it does not supports operators like __lte, __gte, etc * Ensures EmbeddedDocumentField does not accepts references to Document classes in its constructor * minor improvement to DateTimeField doc * Documented that it is possible to specify a name when using a dict to define an index * Fixes 2 bugs in no_subclasses context mgr (__exit__ swallows exception + repair feature) * Fix few things related to query_counter context manager: - Improve doc - Fix the fact that the context was modifying the initial profiling_level in case it was != 0 - Ignores 'killcursors' to fix flaky test that were impacted by killcursors queries (MongoEngine#1869) * reduce cycle complexity using logic map * flip value before changing op to inc * trigger ci * fix inc/dec operator with decimal * reverted back to the StopIteration in queryset.next that one didnt have to be changed (test stalled) * Remove DictField.basecls related code, it is useless * detect when EmbeddedDocumentListField receives an EmbeddedDocument instance instead of a list. It is a common mistake and the error wasn't meaningful (was fired from _from_son) (relates to MongoEngine#1464) * Fix default value of ComplexDateTime + fixed descriptor .__get__ for class attribute * fixed TypeError on translated choices join expect strings, but if we use django ugettext_lazy like this: choices=[(1, _("One")), (2, _("Two"))] there will be TypeError: sequence item 0: expected string, __proxy__ found this commif fixes error by converting label to string * rewrote some poorly written assertions like: assertTrue(isinstance(a, b)) assertTrue(a==b) assertTrue(a!=b) assertTrue(a in b) * fix doc for meta index_options * Update link to index options * fix trailing whitespace * Updating inheritance doc Fixes MongoEngine#429 * improve 2-3 codebase compatibility * fix side effect from queryset's no_dereference MongoEngine#1677
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an -> a