Skip to content

Support show icon when has an external monitor#957

Closed
Demogorgon314 wants to merge 1 commit into
MonitorControl:mainfrom
Demogorgon314:impl/show-icon-when-has-external-monitor-only
Closed

Support show icon when has an external monitor#957
Demogorgon314 wants to merge 1 commit into
MonitorControl:mainfrom
Demogorgon314:impl/show-icon-when-has-external-monitor-only

Conversation

@Demogorgon314
Copy link
Copy Markdown

Since the new Macbook Pro 14 inches has a notch, the menu bar space is limited, I only want menu icons to show when plugging an external monitor, when I unplugged it, the icon should be hidden, so it will save menu bar space.

So I introduced a new menu Icon option: Only if has an external monitor.

@waydabber
Copy link
Copy Markdown
Member

Hey @Demogorgon314 - I think a similar option is already present in the app. If you select Only if at least one slider is present and disable brightness slider for built-in displays by unticking Enable for Apple branded and built-in displays as well then you should achieve something similar, right?

@waydabber
Copy link
Copy Markdown
Member

(note: you are checking against OtherDisplay so in effect the setting you added should have exactly the same result as the approach I described above - external Apple branded displays are AppleDisplay in the app).

@Demogorgon314
Copy link
Copy Markdown
Author

Hey @Demogorgon314 - I think a similar option is already present in the app. If you select Only if at least one slider is present and disable brightness slider for built-in displays by unticking Enable for Apple branded and built-in displays as well then you should achieve something similar, right?

Oh, that is true, my mistake, thanks for telling me.

@Demogorgon314 Demogorgon314 deleted the impl/show-icon-when-has-external-monitor-only branch February 22, 2022 14:56
@waydabber
Copy link
Copy Markdown
Member

Hey @Demogorgon314 - I think a similar option is already present in the app. If you select Only if at least one slider is present and disable brightness slider for built-in displays by unticking Enable for Apple branded and built-in displays as well then you should achieve something similar, right?

Oh, that is true, my mistake, thanks for telling me.

No problem. But as I see you are good at swift so if you'd like to contribute anything else don't hesitate! Thank you! :)

@Demogorgon314
Copy link
Copy Markdown
Author

Hey @Demogorgon314 - I think a similar option is already present in the app. If you select Only if at least one slider is present and disable brightness slider for built-in displays by unticking Enable for Apple branded and built-in displays as well then you should achieve something similar, right?

Oh, that is true, my mistake, thanks for telling me.

No problem. But as I see you are good at swift so if you'd like to contribute anything else don't hesitate! Thank you! :)

Actually, this is my first write the swift code. Please forgive me if there is any mistake and point out my mistake. Thank you! : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants