fix(ui): hide candles under the tick trace, wrap the Detects empty state - #410
Merged
Conversation
…the source caption Where the tick trace covered a span, the 1-minute candles were still painted underneath it, so entry and exit read as two layers on top of each other. The replay series now carries the span the tick walk actually covered, and the window withholds every bar lying wholly inside it; a bar straddling either edge stays, so the edges the caption promises are still closed by candles. The span comes from the walk itself rather than from the tick rows' extrema, because a covered minute in which the venue published no trade would otherwise show a candle in the middle of the trace. The bottom-left source caption moves from the caption size to the body size: it is the one line that says what the window is drawing and was the smallest text on screen.
… a narrow dock The Detects panel's empty-state sentence sat in a centred flex row. GPUI derives a text element's wrap width only from a definite width, so the layout probe measured the whole one-line string as the item's minimum: it could not shrink, overflowed a ~290 px side dock symmetrically and was clipped on both sides, leaving a fragment like «а нет — карточка появится, когда ср» on screen. The element is now a column whose sentence box carries a definite full width with a horizontal inset and centred text, so the sentence wraps onto as many lines as the panel needs and stays one line where the panel is wide. All three empty-state sentences share the site. A static contract pins the shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Two follow-ups from the live review of the previous round:
no longer drawn; candles stay only on the edges the ticks do not cover, and while ticks are
still loading the whole window stays on candles. The bottom-left source caption moves up one
design size — it is the line that says what the window is drawing.
was clipped on both sides in a ~290 px side dock. It is now a column with a definite-width,
centred sentence box and wraps onto as many lines as the panel needs.
How to verify
cargo test --workspaceandcargo fmt --all -- --checkare green. On a live build: aBinance USD-M trade window shows ticks with no candles under them once the fetch lands; the
Detects panel docked narrow shows the whole «Детектов пока нет…» sentence on several lines.