docs(testnet): fix OTLP endpoint + document trace IDs path - #95
Merged
Conversation
- OTEL_EXPORTER_OTLP_ENDPOINT example was `.../otlp/v1/traces`; Deno's HTTP/protobuf exporter appends `/v1/traces` itself, so the working value is the BASE `.../otlp`. With the wrong one suite 2/4 fail with zero SDK spans even though the flow reports success. - Suite 3 writes trace IDs to a CWD-relative file but suite 4 reads from `e2e/e2e-trace-ids.json`. Pin `E2E_TRACE_IDS_PATH` in the run command and document it in the env-vars table.
Re-pad env-vars table after adding the wider E2E_TRACE_IDS_PATH row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two corrections to
testnet/README.mdthat caused suites 2 and 4 to silently fail when followed literally:OTLP endpoint example showed
.../otlp/v1/traces. Deno's HTTP/protobuf OTLP exporter appends/v1/tracesto whatever endpoint is set, so the SDK was shipping to.../otlp/v1/traces/v1/tracesand getting a silent 404. Result: the flow reports success, but suites 2/4 reportE2E step spans (e2e.*): 0 (expected >= 6). The working value is the BASE.../otlp.Trace IDs path mismatch.
lib/client/tracer.tsdefaultsTRACE_IDS_PATHto CWD-relativee2e-trace-ids.json;lifecycle/verify-otel.tsreads frome2e/e2e-trace-ids.json(relative to its own file). Running suite 3 from local-dev/ writes to the wrong location — suite 4 then reads a stale file (or the "trace not found" error). PinnedE2E_TRACE_IDS_PATH=e2e/e2e-trace-ids.jsonin the suite 3 run command and documented it in the env-vars table. Suite 1 dodges this becauserun-tempo.shcd's intotestnet/first.Test plan
E2E_TRACE_IDS_PATH=e2e/e2e-trace-ids.json: 23/23 OTEL checks pass