fix: continue agent after resuming blocked goals#1627
Conversation
🦋 Changeset detectedLatest commit: 5acab86 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…sume # Conflicts: # packages/agent-core-v2/test/agent/prompt/promptService.test.ts # packages/agent-core-v2/test/session/agentLifecycle/agentLifecycle.test.ts
|
@codex review |
commit: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 877217c218
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
…sume # Conflicts: # packages/agent-core-v2/src/agent/goal/goalService.ts # packages/kap-server/test/sessions.test.ts
|
@codex review |
1 similar comment
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
2 participants
Related Issue
No linked issue.
Problem
When a goal became blocked, the Web goal controls could change it back to active, but no new agent turn was started. The goal then looked resumed while execution remained idle.
What changed
goal.updatewire records./api/v1profile adapter explicitly request continuation for a blocked Web resume, while the goal domain continues to own the continuation prompt and loop admission checks.turn.endedwithout an old receipt clearing the new one.The startup serialization commits from the original branch are already present on
mainthrough #1614 and are not part of this PR's effective diff.Validation
pnpm --filter @moonshot-ai/agent-core-v2 exec vitest run test/agent/goal/goal.test.ts(55 passed)pnpm --filter @moonshot-ai/kap-server exec vitest run test/sessions.test.ts test/rpc.test.ts(77 passed)pnpm --filter @moonshot-ai/agent-core-v2 test(3263 passed)pnpm --filter @moonshot-ai/kap-server test(618 passed)pnpm run test --shard=4/5(3044 passed, 19 skipped)lint:domaincheck:stylepnpm changeset status --since=origin/maingit diff --checkChecklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update. Existing EN/ZH goal docs already describe/goal resumefor blocked goals.