fix(tui): reduce frequent full-screen redraws - #2442
Merged
Conversation
🦋 Changeset detectedLatest commit: 47ab1f4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 47ab1f4d18
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Merged
Pidbid
added a commit
to Pidbid/kkm
that referenced
this pull request
Jul 31, 2026
Pidbid
added a commit
to Pidbid/kkm
that referenced
this pull request
Jul 31, 2026
…or/custom-editor.ts
Pidbid
added a commit
to Pidbid/kkm
that referenced
this pull request
Jul 31, 2026
Pidbid
added a commit
to Pidbid/kkm
that referenced
this pull request
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
N/A — the problem is explained in the next section.
Problem
Several frequent TUI interactions forced a destructive full-screen redraw (clear screen + clear scrollback + repaint everything): toggling tool output expansion with Ctrl+O, closing any
mountEditorReplacementdialog or selector, dismissing the autocomplete menu, and resetting the session via /clear or /new. On long sessions this caused visible full-screen flicker and wiped the terminal scrollback, so users lost the ability to scroll up.What changed
Removed the four app-level forced full renders so these interactions go through pi-tui's differential renderer instead:
toggleToolOutputExpansion) now requests a normal render.restoreEditor(used when closing every dialog/selector) drops the overflow probe and tmux special case; it renders differentially.Notes:
tsc --noEmitand oxlint are clean.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.