fix(kimi-code): render v2 background task notifications on session replay - #2677
Merged
Conversation
🦋 Changeset detectedLatest commit: 676a67e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue — the problem is explained below.
Problem
When the TUI runs on the v2 engine, resuming a session renders background-task terminal notifications as raw
<notification ...>XML user messages instead of the usual task status card.The v2 engine persists these notifications with prompt origin kind
task(renamed from v1'sbackground_task), and both spellings reach the replay verbatim. The TUI's replay path only recognized the legacy spelling, so a v2-spelled notification fell through every special-case branch and landed in the generic user-message renderer, leaking the protocol XML into the visible transcript.What changed
background_taskandtask). The v2 spelling is declared as a local origin type because the SDK'sPromptOriginunion only carries the v1 vocabulary; both shapes share the sametaskId/status/notificationIdfields and identical status value sets, so the status-card renderer works unchanged — only its parameter type was widened.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.