fix(sdk): probe MCP auth status through connection - #2731
Conversation
🦋 Changeset detectedLatest commit: e041cc3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a2b0cbf3d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Related Issue
Follow-up to the global MCP auth-status RPC added in #2706.
Problem
The auth-status RPC only reported OAuth when the config explicitly contained
auth: "oauth". Kimi Code already classifies an uncredentialed HTTP MCP asneeds-authwhen the existing connection probe receives a 401, but the status RPC did not reuse that result.What changed
testGlobalMcpServerand auth-status detection.needs-authresult tooauth-requiredfor markerless HTTP servers without static headers or stored tokens.The connection manager, 401 classification, OAuth begin/service/provider, token refresh, and configuration schema are unchanged.
Validation
@moonshot-ai/agent-coretypecheck passed.@moonshot-ai/kimi-code-sdktypecheck passed.Checklist