reprexes: port review-driven fixes from lab-manual PR #282 - #147
Merged
Conversation
The reprexes skill landed upstream here before UCD-SERG/lab-manual PR #282 finished its review rounds, so five improvements developed on that PR's branch never reached this copy. lab-manual reads the skill through the .ai-config submodule, so the stale copy is what collaborators and the @claude CI bot actually use. Port the fixes: - Rscript --vanilla in the clean-session step, so it skips .Rprofile / .Renviron instead of silently sourcing them. - Drop the inaccurate "since reprex 2.0" qualifier on callr-backed execution (callr predates reprex 2.0). - Namespace the remaining reprex-package calls (reprex::reprex(input=), reprex::reprex_clean/_rescue/_invert, and the validation-bonus reference) so they work without library(reprex). - Add blank lines before the nested lists in step 2 and under "Useful arguments:" for CommonMark-correct rendering. reprex_invert() was flagged as a possible hallucination during review; confirmed it is a real exported function in the reprex NAMESPACE. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VczBpwQw7cXiiPAiiosmoi
Contributor
|
Claude finished @d-morrison's task in 1m 45s —— View job Review: clean ✅
No hallucinations found. The "all exported in reprex 2.x" qualifier on the companion-helpers line was pre-existing and unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
reprexesskill landed upstream here before UCD-SERG/lab-manual#282 finished its review rounds. Five improvements developed on that PR's branch never reached this copy. Since lab-manual reads the skill through the.ai-configsubmodule (.claude/skills → .ai-config/skills), this stale copy is what collaborators and the@claudeCI bot actually use — so PR #282 became a no-op and the fixes were stranded in its branch history.This PR ports those fixes into
skills/reprexes/SKILL.md.What changed
Rscript --vanillain the clean-session step (step 3). Without--vanilla,Rscriptstill sources.Rprofile/.Renviron, which contradicts the "clean session" framing; the flag skips them.callr-backed execution.callr-backed clean-session execution predates reprex 2.0, so the version claim was wrong.reprex::reprex(input = ...),reprex::reprex_clean()/_rescue()/_invert(), and the validation-bonus reference — so they work without an explicitlibrary(reprex).sessionInfo()stays bare (base R);tidyverse::tidyverse_update()was already namespaced.Note on the
reprex_invert()flagThe last review round on #282 flagged
reprex_invert()as a possible hallucinated function name. It is real — confirmed exported in the reprex NAMESPACE. The text is ported as-is.Follow-up
Once this merges, the
.ai-configsubmodule pin inUCD-SERG/lab-manualshould be bumped to pick it up (the weeklybump-ai-config.ymlworkflow does this automatically). PR #282 will be closed as superseded.🤖 Generated with Claude Code
Generated by Claude Code