memorize: always verify math actually renders - #155
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Collaborator
Author
|
Driving this PR to clean — back off until done. |
Addresses PR #155 review: the hardcoded pr-772 preview link is ephemeral (deleted when that PR closes) — the very anti-pattern the rule warns against; use a pr-<N> placeholder. And match 'never assume; always verify' wording. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
ARD summary — round 1
Also merged current |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new standing preference to the repository’s recorded guidelines: when editing LaTeX/Quarto math, verify the rendered output (HTML/MathJax) visually rather than relying solely on a successful build.
Changes:
- Documented a “verify math renders” rule with examples of common math syntaxes.
- Added a concrete verification workflow example using the rme PR preview HTML page pattern.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
ARD summary — round 2Both round-1 findings confirmed fixed. One non-blocking observation remained:
No code changed this round, so re-requesting a confirming review. @claude review |
Contributor
|
👀 Picked up by workflow run #27979718767. Setup runs first; Claude itself responds after that. |
Collaborator
Author
|
Done — PR is clean (CI green, no review findings, all inline threads resolved). PR is free. |
d-morrison
added a commit
that referenced
this pull request
Jun 22, 2026
…URLs (#159) UMS follow-up from PR #155's review lifecycle. - skills/memorize/SKILL.md: document the worktree / occupied-main-checkout case. ~/.claude/memories and ~/.claude/CLAUDE.md symlink to the MAIN checkout, so rev-parse --show-toplevel resolves there, not your worktree; if that checkout is on another branch, edit the memory in your worktree and land it via branch+PR+merge. - memories/preferences.md: extend the "don't bake a volatile value into prose" rule to cover ephemeral example URLs (PR-preview links, PR numbers) — parameterize the ephemeral part (pr-<N>).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Captures a standing preference: when adding or changing math (LaTeX/Quarto
equations), verify it actually renders — open the rendered HTML page and
confirm the equation displays, not just that the build succeeded. A typo in a
macro can silently break MathJax while the build still passes.
Added one bullet to
memories/preferences.md, next to the existinginline-R-expressions rule, framed as an instance of never assume; always
verify applied to math. Example given is the rme PR preview.
Came from a direct user directive ("always check that math you add or change
actually renders"), recorded via the
memorizeskill.🤖 Generated with Claude Code