ums: skill-builder must regenerate codex-skills wrappers + run validate before push - #233
Conversation
…te before push A new skill needs its generated codex-skills/<name>/ wrapper committed alongside the source, or the `validate` CI job fails on the wrapper-sync check. The Ship-it steps didn't mention it — surfaced while adding the check-rendered-refs skill (PR #231). Add `scripts/sync-codex-skill-wrappers.py` + `scripts/validate-skills.py` to the commit block and a paragraph explaining why. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Driving this PR to clean — back off until done. |
This comment has been minimized.
This comment has been minimized.
…er in git add Addresses PR #233 review: (1) the parenthetical quoted the success message; a reader debugging a red CI log searches for the failure string, so quote "Codex skill wrappers are out of sync:" instead. (2) the git add code block staged only codex-skills/<name>; add the <alias> source + wrapper so a copy-paste of both-skill-plus-alias doesn't push a stale alias wrapper. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ARD round 1
Pushed in e2b2cca. Re-review runs on the push. |
|
Claude finished @d-morrison's task in 1m 18s —— View job Re-review after e2b2cca
Both findings from the prior review are correctly addressed. No new issues found. Fix 1 — verified.
This matches Fix 2 — verified. The git add skills/<name>/SKILL.md codex-skills/<name> \
skills/<alias>/SKILL.md codex-skills/<alias> \
memories/preferences.mdThe inline comment No new findings. PR is clean. |
|
Done — PR is fully clean and free. |
A new skill needs its generated codex-skills// wrapper committed alongside
the source, or the
validateCI job fails on the wrapper-sync check. The Ship-itsteps didn't mention it — surfaced while adding the check-rendered-refs skill
(PR #231). Add
scripts/sync-codex-skill-wrappers.py+scripts/validate-skills.pyto the commit block and a paragraph explaining why.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com