ums: diagnosing missing @claude reviews (dispatch chain, allowed_bots, workflow drift) - #235
Merged
Merged
Conversation
…s gate, gha workflow drift Captured from rme #944/#945/#946/#948: - trace @claude review failures to the dispatched claude-code-review.yml run, not the green agent run - anthropics/claude-code-action's allowed_bots actor gate (separate from the job if:) - consumer repos may carry a standalone review workflow that drifted from gha's reusable one; prefer migrating to the @v1 caller
This comment has been minimized.
This comment has been minimized.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
…-steps' wording - distinguish the action's `allowed_bots` with: key (underscore) from the gha reusable's `allowed-bots` workflow_call input (hyphen) - the dispatch is a regular later step, not an Actions post-step (cleanup hook)
This comment has been minimized.
This comment has been minimized.
…plain Per ai-tells guidance, emphatic all-caps in prose is an LLM tell. Convert SUCCEEDS/OWN/NOT to bold and STANDALONE/DRIFTED to plain lowercase.
This comment has been minimized.
This comment has been minimized.
Contributor
|
👀 Picked up by workflow run #28272179717. Setup runs first; Claude itself responds after that. |
Contributor
|
Claude finished review — View run The haiku agent found that Claude has already commented on PR #235 with a complete review (two rounds of feedback, all findings resolved, verdict "fully clean"). Per the review workflow, I'll stop here since that condition is met. Result: Skipping review — Claude has already commented on PR #235 with a complete multi-round review. The prior verdict was "fully clean" with all findings resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UMS capture from this session's work on rme #944 / #945 / #946 / #948 (the "why didn't
@claude reviewgenerate a review on PR #706" investigation and fix).Adds three bullets to
memories/tools.mdunder ## @claude CI action:Trace the whole dispatch chain. An
@claude reviewcomment fires the agent workflowclaude.yml, which succeeds and then re-dispatchesclaude-code-review.ymlviaworkflow_dispatch. A green agent run with no review comment means the review died in the separately-dispatched run — find it viaactions_list(event=workflow_dispatch) and read its failed logs. Don't stop at the agent run's green check.The
allowed_botsactor gate.anthropics/claude-code-actionaborts bot-initiated (github-actions[bot]) runs unlessallowed_botslists the bot — a gate separate from the workflow's job-levelif:. Setallowed_bots: "github-actions[bot]".Standalone-vs-reusable drift. Some consumer repos carry a hand-maintained
claude-code-review.ymlthat has drifted from gha's reusable@v1(that drift is how theallowed_botsbug reached rme). Check gha first; prefer migrating to a thin reusable-workflow caller so it can't drift again.One file changed; staged that file only.
Generated by Claude Code