Add per-operation grouping review guideline for dplyr - #239
Merged
Conversation
Flag persistent group_by()/ungroup() pairs in code review when the .by argument would scope the grouping to a single operation instead. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UZVwdp2UkrhAUDrh2cwdfC
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
Driving this PR to clean — back off until done. Generated by Claude Code |
Simplify closing sentence: replace i.e. with "that is" and reduce stacked subordinate clauses per the plain-prose guideline. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UZVwdp2UkrhAUDrh2cwdfC
Collaborator
Author
|
ARD summary
Generated by Claude Code |
This comment has been minimized.
This comment has been minimized.
Split stacked subordinate clauses into two sentences per plain-prose guideline. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UZVwdp2UkrhAUDrh2cwdfC
Collaborator
Author
|
ARD summary — round 2
Generated by Claude Code |
Contributor
|
Claude finished @d-morrison's task in 1m 29s —— View job Review
Prior finding confirmed addressed. The round-2 inline finding — opening sentence at lines 3–5 stacking two subordinate clauses ("When reviewing or writing R code that uses No new findings. Checked:
This PR is fully clean. |
Collaborator
Author
|
Done — PR is free. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shared/coding/per-operation-grouping.mdwith guidance to prefer dplyr's.byargument over persistentgroup_by()/ungroup()pairs when grouping is only needed for one operation.CLAUDE.mdalongside the other coding guidelines.Reference: https://dplyr.tidyverse.org/reference/dplyr_by.html
Example flagged in review: https://github.com/ucdavis/rampp/pull/125/changes/#diff-ef2f6f6745046859ccc877eb26de77f63a99edc851687c9fa053788458f7f731R265-R267
Generated by Claude Code