UMS: note the cross-repo citation merge-order trap - #331
Conversation
Encodes what ai-config#324/gha#151's own review loop demonstrated: citing a specific file path in another repo's not-yet-merged PR is itself an unverifiable claim, and 404s the link checker. Cite the repo generically until the referenced PR merges.
This comment has been minimized.
This comment has been minimized.
| **Cross-repo citations have a merge-order trap.** Citing a specific file path | ||
| or construct in another repo is itself unverifiable --- and will 404 a link | ||
| checker --- if the PR that adds it hasn't merged yet. Name the repo generically | ||
| until the referenced PR merges, then tighten the citation to the specific path |
There was a problem hiding this comment.
The pronoun "it" in "once it resolves" is ambiguous — "it" could refer to "the referenced PR", "the citation", or "the situation" — and "resolves" is not the usual verb for a PR lifecycle event (PRs "merge" or "close", not "resolve"). Prefer the explicit subject:
| until the referenced PR merges, then tighten the citation to the specific path | |
| once the referenced PR merges. (Caught by this very guideline, twice, while adding it to |
Or, to keep the two-clause structure intact:
...then tighten the citation to the specific path once the referenced PR merges.
'once it resolves' had no clear antecedent and 'resolves' isn't the usual verb for a PR lifecycle event; say 'once the referenced PR merges' instead.
|
Claude finished @d-morrison's task in 1m 12s —— View job Review
Clean — prior nit addressed, no new findings. The prior review (2026-07-01T21:58:53Z) found one nit: Verification of the fix: Line 24 now reads:
Explicit subject, idiomatic verb — exactly what the suggestion called for. No new issues. The remaining "it" on line 26 ( |
Summary
shared/workflow/challenge-ambiguous-terminology.md: citing a specific file path in another repo's not-yet-merged PR is itself unverifiable, and will 404 a link checker. Cite the repo generically until the referenced PR merges, then tighten.Context
Captured from ai-config#324 / gha#151's own review loop: the guideline caught this exact pattern twice while being added to
gha'sCLAUDE.md— the cited file only existed on ai-config#324, which hadn't merged yet, so both a direct link (404 in lychee) and a bare path citation got flagged by the reviewer as instances of the very anti-pattern the guideline warns against.Test plan
Generated by Claude Code