Skip to content

UMS: note the cross-repo citation merge-order trap - #331

Merged
d-morrison merged 2 commits into
mainfrom
ums-cross-repo-citation-merge-order
Jul 1, 2026
Merged

UMS: note the cross-repo citation merge-order trap#331
d-morrison merged 2 commits into
mainfrom
ums-cross-repo-citation-merge-order

Conversation

@d-morrison

Copy link
Copy Markdown
Collaborator

Summary

  • Adds a short note to shared/workflow/challenge-ambiguous-terminology.md: citing a specific file path in another repo's not-yet-merged PR is itself unverifiable, and will 404 a link checker. Cite the repo generically until the referenced PR merges, then tighten.

Context

Captured from ai-config#324 / gha#151's own review loop: the guideline caught this exact pattern twice while being added to gha's CLAUDE.md — the cited file only existed on ai-config#324, which hadn't merged yet, so both a direct link (404 in lychee) and a bare path citation got flagged by the reviewer as instances of the very anti-pattern the guideline warns against.

Test plan

  • Doc-only fragment edit; no CI-affecting code touched.

Generated by Claude Code

Encodes what ai-config#324/gha#151's own review loop demonstrated:
citing a specific file path in another repo's not-yet-merged PR is
itself an unverifiable claim, and 404s the link checker. Cite the
repo generically until the referenced PR merges.
@claude

This comment has been minimized.

**Cross-repo citations have a merge-order trap.** Citing a specific file path
or construct in another repo is itself unverifiable --- and will 404 a link
checker --- if the PR that adds it hasn't merged yet. Name the repo generically
until the referenced PR merges, then tighten the citation to the specific path

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pronoun "it" in "once it resolves" is ambiguous — "it" could refer to "the referenced PR", "the citation", or "the situation" — and "resolves" is not the usual verb for a PR lifecycle event (PRs "merge" or "close", not "resolve"). Prefer the explicit subject:

Suggested change
until the referenced PR merges, then tighten the citation to the specific path
once the referenced PR merges. (Caught by this very guideline, twice, while adding it to

Or, to keep the two-clause structure intact:

...then tighten the citation to the specific path once the referenced PR merges.

'once it resolves' had no clear antecedent and 'resolves' isn't the
usual verb for a PR lifecycle event; say 'once the referenced PR
merges' instead.
@claude

claude Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Claude finished @d-morrison's task in 1m 12s —— View job


Review

  • Gather context
  • Read current diff
  • Verify pronoun fix from prior review
  • Check for new issues
  • Post findings

Clean — prior nit addressed, no new findings.

The prior review (2026-07-01T21:58:53Z) found one nit: "once it resolves" at line 24 was ambiguous ("it") and used "resolves" for a PR lifecycle event. That finding still stands — and commit 00e6cb0 correctly addresses it.

Verification of the fix: Line 24 now reads:

until the referenced PR merges, then tighten the citation to the specific path.

Explicit subject, idiomatic verb — exactly what the suggestion called for.

No new issues. The remaining "it" on line 26 ("the file it pointed at") refers to the citation being made, which is the subject of the whole parenthetical; clear in context and not the same ambiguity as "once it resolves." Content is accurate, the gha#151 reference is corroborated by the PR body, and no hallucinated paths or fabricated symbols were found.

@d-morrison
d-morrison merged commit 7cf0fea into main Jul 1, 2026
5 checks passed
@d-morrison
d-morrison deleted the ums-cross-repo-citation-merge-order branch July 1, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants