Skip to content

links / link-checker is red on main: 17 prose issue URLs 404 after the org moveΒ #353

Description

@dem-extra1

Symptom

links / link-checker fails on main, and therefore on every PR branched from it. From job 90363565855:

| βœ… Successful  | 152   |
| πŸ”€ Redirected  | 42    |
| 🚫 Errors      | 17    |

All 17 errors are 404, and all 17 are issue URLs under the old org.

Cause

GitHub's repository-transfer redirect covers repository, tree, blob, and pull paths, but not issues paths. So after the move to Morrison-Lab:

URL shape Result
d-morrison/gha/pull/34 301 β†’ Morrison-Lab/... βœ…
d-morrison/gha/tree/main/examples 301 β†’ Morrison-Lab/... βœ…
d-morrison/gha/issues/325 404 ❌

The redirects are not themselves a problem β€” check-links/lychee.default.toml lists 301 and 302 in its accept array, so the 42 redirected links pass. Only the issue links fail.

The issues all still exist at the new org. Verified by request: Morrison-Lab/gha/issues/ 143, 182, 252, 254, 262, 325 and Morrison-Lab/ai-config/issues/ 401, 702 all return 200. So this is a link-rewriting job, not a data-recovery one.

Affected files

File Broken links
website/workflows.qmd gha/issues/ 143, 182, 252, 254, 325
README.md the same five
REVDEPS.md gha/issues/75, ai-config/issues/401, ai-config/issues/702
changelog.d/fix-preview-family-stale-v1-examples.fixed.md ai-config/issues/401, gha/issues/182
changelog.d/raise-deno-v8-heap-cap.fixed.md gha/issues/262
changelog.d/report-failure.added.md gha/issues/325

Fix

Rewrite https://github.com/d-morrison/{gha,ai-config}/issues/N β†’ https://github.com/Morrison-Lab/{gha,ai-config}/issues/N across those files. Note the second org: d-morrison/ai-config has moved to Morrison-Lab/ai-config as well, so a sweep scoped to gha alone will not clear the check.

Two things a blanket d-morrison β†’ Morrison-Lab sweep would get wrong:

  1. Keep .github/actions/parse-workflow-ref/tests/run-tests.sh's fixtures as-is. They are inputs to a string parser, not links β€” Retarget every uses: reference to Morrison-Lab/ghaΒ #351 already makes this point.
  2. Non-URL references are out of scope. Bare d-morrison/gha#336-style text and issue-reference prose are not resolved by lychee, and rewriting them is a naming decision rather than a fix. Retarget every uses: reference to Morrison-Lab/ghaΒ #351 deliberately scoped those out; this issue should too.

gha/issues/75 is the one link I could not verify from my sandbox (its request returned 403 from an egress proxy rather than from GitHub), so confirm that one by hand before assuming a plain rewrite covers it.

Relationship to #351

#351 retargeted 105 uses: references and fixed the workflow was not found startup failure. It deliberately left prose references alone on the grounds that they "still resolve through GitHub's web redirect, so they are stale rather than broken." That reasoning holds for repo/tree/blob/pull links and does not hold for issue links, which is why the check is still red after #351 merged.

Found while reviewing #337, #348, and #351.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions