docs: generalize the self-verify-gap note to cover claude.yml too - #291
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Contributor
|
Claude finished review — View run Review: #291 — "docs: generalize the self-verify-gap note to cover claude.yml too"Change scope: Docs-only edit to a single section of Verification performed:
No prior Findings: None. The generalization is accurate, well-cited, and consistent with the rest of the file. VerdictReady for merge |
Contributor
d-morrison
added a commit
that referenced
this pull request
Jul 24, 2026
…cause (#294) * docs: note the in-workflow self-mod guard as a third self-verify-gap cause Complements #291's @v2-floating-tag explanation with the mechanism this session actually hit on #286: claude-code-review.yml's own 'Skip self-review when the PR edits this workflow' step, which skips every downstream step (not just runs a stale pre-fix version) when the PR touches the caller review workflow's own file. Both claude-review / require-review report success with no verdict ever posted -- easy to mistake for a real review unless the job's step list (not just its conclusion) is checked. * Fix overstated file list in self-mod-guard note Review finding on #294: the guard checks exactly one path (github.workflow_ref, the caller's own stub -- claude-review.yml in this repo's dogfooding setup), not all three files previously listed. claude.yml has no analogous self-mod check at all; examples/claude- code-review.yml never executes as a workflow here, so github.workflow_ref can't resolve to it either. Clarify scope and correct the trigger condition. --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLAUDE.md's "A PR fixing claude-code-review.yml itself can't self-verify before merge" section only namedclaude-code-review.yml's own@v2pin (viaclaude-review.yml). PR claude-code-review's workflow_dispatch re-review posts a successful require-review check tied to the wrong commit SHA #286 (fixing claude-code-review's workflow_dispatch re-review posts a successful require-review check tied to the wrong commit SHA #285) hit the identical bootstrapping gap throughclaude.yml@v2instead: a plain@claude reviewcomment posted mid-PR dispatched throughclaude-bot.yml'sclaude.yml@v2— the released, pre-fix tag — and reproduced the exact claude-code-review's workflow_dispatch re-review posts a successful require-review check tied to the wrong commit SHA #285 symptom live (the re-dispatched review's check-run landed onmain's SHA, not the PR's head), even though the fix had already been pushed to the PR branch.Docs-only change, no functional edits.
Test plan
Generated by Claude Code