fix(quarto-publish): pass GH_TOKEN to the Quarto setup step so TinyTeX install doesn't 403 - #431
Conversation
…X install doesn't 403
quarto-publish/action.yml's 'Set up Quarto' step called quarto-actions/setup
with tinytex but no GH_TOKEN. With tinytex: true, 'quarto install tinytex'
looks up the latest rstudio/tinytex-releases release via an UNauthenticated
GitHub API call, which intermittently fails on shared runners with:
ERROR: Unable to determine latest release for rstudio/tinytex-releases
403 - Forbidden
Add env: GH_TOKEN: ${{ github.token }} to that step, matching the preview
composite (which already authenticates the identical setup step). Internal to
the composite -- no new input -- so the reusable workflow (which just calls
the composite) and the example stub need no change.
Closes #270
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
370b7e6 to
44541de
Compare
|
Claude finished review — View run Code review — PR #431Summary: Adds Findings from this review:
No AI-hallucination concerns (no fabricated APIs/symbols — VerdictReady for merge (with an optional non-blocking follow-up to close the same gap in |
ARD summaryVerdict Ready for merge; the diff itself is verified correct against the The one non-blocking finding (two other Quarto-setup call sites -- Not folded in here on purpose: both are The changelog fragment is already scoped to |
Closes #270
The bug
quarto-publish/action.yml's "Set up Quarto" step calledquarto-dev/quarto-actions/setupwithtinytex: ${{ inputs.tinytex }}but noGH_TOKEN. Withtinytex: true,quarto install tinytexlooks up the latestrstudio/tinytex-releasesrelease via an unauthenticated GitHub API call,which intermittently fails on shared runners:
This repeatedly broke
ucdavis/win's builds (per #270) until its bespoke stepgot the token.
The fix
Add
env: GH_TOKEN: ${{ github.token }}to that step, so the release lookup isauthenticated. This mirrors the
previewcomposite, whose identical"Set up Quarto" step already passes
GH_TOKEN: ${{ github.token }}(in-repoprecedent).
Scope
The change is internal to the composite -- no new input, no interface change.
The reusable workflow
.github/workflows/quarto-publish.ymljust callsMorrison-Lab/gha/quarto-publish@v2(it does not duplicate the setup step), sothe fix propagates automatically; the
examples/quarto-publish.ymlstub needsno change. Only callers with
tinytex: trueare affected.