Skip to content

update main with security patches & lp updates - #196

Merged
Giselle Rogers (gbrogers) merged 4 commits into
mainfrom
staging
Aug 3, 2026
Merged

update main with security patches & lp updates#196
Giselle Rogers (gbrogers) merged 4 commits into
mainfrom
staging

Conversation

@gbrogers

Copy link
Copy Markdown
Contributor

No description provided.

vamsi (thedumsieffect) and others added 4 commits August 3, 2026 07:36
* ci: add dependency audit and test workflows

* ci: keep package checks on Node 20
* fix(frontend): upgrade React Router to v8

* fix(ci): avoid caching absent pnpm store
* fix(deps): resolve use-case library advisories

* fix(ci): avoid caching absent pnpm store
Swaps only the lesson 5 block (title, topic, takeaway, in-your-work) from 'Launch your ads from Slack' to 'Train AI to name ads exactly like you'. Lessons 1-4 and everything else on the page are untouched.
@gbrogers
Giselle Rogers (gbrogers) requested a review from a team August 3, 2026 17:38
@greptile-apps

greptile-apps Bot commented Aug 3, 2026

Copy link
Copy Markdown

Confidence Score: 2/5

The BrowserRouter import in main.tsx resolves to undefined under React Router v8, causing the entire frontend to crash on load — the PR should not be merged until that import is moved to react-router/dom.

Every other change in this PR is clean: the security overrides are well-formed, the @fastify/static v10 upgrade is compatible with the existing server registration, and the new CI workflows look correct. However, the React Router v8 migration left BrowserRouter being imported from react-router instead of react-router/dom, which is a definite app-breaking regression that would surface immediately in production.

Files Needing Attention: use-case-library-site/frontend/src/main.tsx — the BrowserRouter import needs to change from 'react-router' to 'react-router/dom' before this can ship safely.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Browser loads SPA] --> B[main.tsx: import BrowserRouter from 'react-router']
    B --> C{RR v8: BrowserRouter\nexported from root?}
    C -- "No (moved to react-router/dom)" --> D["BrowserRouter = undefined"]
    D --> E["React: Element type is invalid\n(expected function, got undefined)"]
    E --> F[App crashes on mount]

    C -- "Fix: import from 'react-router/dom'" --> G[BrowserRouter resolves correctly]
    G --> H[App mounts: BrowserRouter wraps AppShell]
    H --> I{REVAMP_MODE?}
    I -- true --> J[Render Revamp component]
    I -- false --> K[Render CatalogApp with Routes]
    K --> L[Route / → Home]
    K --> M[Route /all → All]
    K --> N[Route /use-case/:slug → LegacyDetailRedirect]
    K --> O[Route * → Navigate to /]
Loading

Reviews (1): Last reviewed commit: "Update ATC LP lesson 5 to the AI ad-nami..." | Re-trigger Greptile

Comment thread use-case-library-site/frontend/src/main.tsx
@gbrogers
Giselle Rogers (gbrogers) merged commit 397a268 into main Aug 3, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants