Skip to content

feat(env): add NumPy manager-based lifecycle - #1051

Merged
TATP-233 merged 1 commit into
dev/issue-1042-manager-based-apifrom
feat/issue-1049-manager-based-lifecycle
Aug 17, 2026
Merged

feat(env): add NumPy manager-based lifecycle#1051
TATP-233 merged 1 commit into
dev/issue-1042-manager-based-apifrom
feat/issue-1049-manager-based-lifecycle

Conversation

@TATP-233

Copy link
Copy Markdown
Collaborator

Summary

  • add the canonical NumPy ManagerBasedRlEnv / ManagerBasedRlEnvCfg lifecycle on top of the single existing NpEnv.step/reset/autoreset path
  • preserve NpEnvState, explicit policy/critic observation mapping, timeout semantics, final observations, manager ordering, recorder hooks, and env-owned RNG/control buffers
  • fail closed at construction for unsupported mjwarp multi-substep callbacks and per-substep metrics; do not add legacy DR, backend-private, IPC, runner, or fallback paths

Scope accounting

  • 9 files changed: +1,229 / -22
  • source-derived copied code: 0 lines (the pinned mjlab lifecycle semantics are implemented through the existing UniLab NpEnv; no second upstream loop is vendored)
  • mechanical Torch → NumPy adaptation: 0 standalone lines in this child (completed in the manager-package child)
  • UniLab-specific implementation: 718 production additions; adapted/focused tests: 511 additions
  • modified existing: 7 files; new: 2 files; deleted: 22 lines / 0 files

Validation

  • focused manager/lifecycle tests: 123 passed
  • representative regression: 387 passed, 14 skipped, 1 xfailed
  • make test-all: 1,833 passed, 24 skipped, 1 xfailed; ruff, mypy, and pyright passed; benchmark smoke 65/67 with only the two optional mlx cases skipped

Implements #1049
Umbrella: #1042

@TATP-233
TATP-233 merged commit 211c48d into dev/issue-1042-manager-based-api Aug 17, 2026
7 checks passed
@TATP-233
TATP-233 deleted the feat/issue-1049-manager-based-lifecycle branch August 17, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant