Skip to content

feat(config): route manager reward overrides - #1071

Merged
TATP-233 merged 1 commit into
dev/issue-1042-manager-based-apifrom
feat/issue-1070-manager-reward-routing
Aug 17, 2026
Merged

feat(config): route manager reward overrides#1071
TATP-233 merged 1 commit into
dev/issue-1042-manager-based-apifrom
feat/issue-1070-manager-reward-routing

Conversation

@TATP-233

Copy link
Copy Markdown
Collaborator

Summary

  • resolve the Hydra root reward target from the registered env config owner
  • route legacy configs to reward_config and explicitly marked Manager-Based configs to rewards
  • reject unregistered/missing/ambiguous targets and duplicate root/env.rewards sources
  • preserve Python-owned reward callables, sibling terms, insertion order, and legacy dict replacement semantics

Implements #1070.
Part of #1042.

Scope accounting

  • source-derived code: 0 lines
  • mechanical conversion: 0 lines
  • UniLab-specific implementation/glue: 64 added, 5 deleted lines
  • tests: 139 added lines
  • files changed: 4

Validation

  • focused routing tests: 6 passed
  • registry/config/training/script regression: 204 passed
  • make test-all:
    • ruff, mypy, pyright passed
    • pytest: 1927 passed, 25 skipped, 274 deselected, 1 xfailed
    • benchmark module mode: 32/33 passed, 1 platform-optional skip
    • benchmark script mode: 33/34 passed, 1 platform-optional skip

@TATP-233
TATP-233 merged commit 31f25c1 into dev/issue-1042-manager-based-api Aug 17, 2026
7 checks passed
@TATP-233
TATP-233 deleted the feat/issue-1070-manager-reward-routing branch August 17, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant