chore: remove temporary MBA profiling scaffolding - #1285
Merged
TATP-233 merged 1 commit intoAug 24, 2026
Merged
Conversation
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1281
Scope
Remove the temporary fine-grained MBA profiling introduced for #1255/#1256 while preserving production behavior and the retained coarse-grained timing contract.
mba_reset_*,mba_update_*, per-term/getter/observation phase timing, dynamic timing dictionaries/zero-fill, EventManager reset timing, getter recorder, and benchmark display/tests.physics_ms,update_state_ms,reset_done_ms, directdr_reset_*, backend timing/behavior, the U1 state-read cache, reset transaction, R2 row-scoped reset observation, lifecycle/RNG/numerics.The final diff is 16 files, 20 insertions, and 700 deletions. The issue's 15-file stop condition was reached by four one-line/tiny fixture cleanups required to remove dead recorder wiring; the maintainer explicitly authorized the 16-file exception before proceeding.
Backend behavior impact
No intended MuJoCo or Motrix behavior change. Exact same-seed/action parity was checked across initial observation, normal steps, partial reset observation, reward, termination/truncation, final observation, and post-reset step, including two forced timeout/autoresets per backend:
Validation
make test-allmba_timing key remains.65546bbe45af515262939af19b463f3f2fdf2afc.#1281 before/after throughput
Same host and parameters, three independent serial runs per side: 8192 envs, warmup 10, measure 100, replay capacity 64, Torch threads 8. Values are median Collector/s with
[min, max]; delta is after/before median.5215ddcd65546bbeThe pre-cleanup
sac/g1_motion_tracking/motrixseries retained the known high-drift outlier (50,473); the post-cleanup series was 63,167/63,333/63,244. Raw JSON/CSV files are saved under the benchmark output directory and intentionally remain untracked.