Skip to content

fix(miglayout): setRowConstraints uses col constraints#25

Merged
stefaniamak merged 1 commit into
release/v1.xfrom
fix/miglayout-row-constraints
Sep 12, 2020
Merged

fix(miglayout): setRowConstraints uses col constraints#25
stefaniamak merged 1 commit into
release/v1.xfrom
fix/miglayout-row-constraints

Conversation

@jdrueckert
Copy link
Copy Markdown
Member

No description provided.

@jdrueckert jdrueckert added the Type: Bug Issues reporting and PRs fixing problems label Sep 5, 2020
@jdrueckert jdrueckert self-assigned this Sep 5, 2020
Copy link
Copy Markdown
Collaborator

@stefaniamak stefaniamak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly sure how to test this 🤔 My only thought was to set a columnConstrain at the Game Over Screen, where I also had a rowConstain, and see if the issue I had of the columnConstrains not working was fixed. It didn't.. 😞

In screenshot: it was supposed to give 450 width at the UISpace at the last out of the three columns.
image

@jdrueckert
Copy link
Copy Markdown
Member Author

@stefaniamak let's put it like this: I didn't expect to achieve wonders with this but merely to fix the obvious copy&paste bug that setRowConstraints should use row constraints and not (as it currently does) col constraints...
To properly fix nui aspects like these constraints a deeper and more time-consuming investigation is necessary, which should definitely be done but not by this PR 😅

Copy link
Copy Markdown
Collaborator

@stefaniamak stefaniamak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see! Then considering everything run how it was supposed to run - I did run files which used these methods as well - I believe this PR is good for merging 👍

@stefaniamak stefaniamak merged commit 8bfd1db into release/v1.x Sep 12, 2020
@stefaniamak stefaniamak deleted the fix/miglayout-row-constraints branch September 12, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Issues reporting and PRs fixing problems

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants