mb/google/puff: UEFI 16MiB FMD and Kaisa chromebox tuning#37
Closed
jackadam1981 wants to merge 1 commit into
Closed
mb/google/puff: UEFI 16MiB FMD and Kaisa chromebox tuning#37jackadam1981 wants to merge 1 commit into
jackadam1981 wants to merge 1 commit into
Conversation
jackadam1981
force-pushed
the
pr/2-kaisa-uefi-baseline
branch
from
73ca52b to
eed8258
Compare
This was referenced Jun 24, 2026
jackadam1981
force-pushed
the
pr/2-kaisa-uefi-baseline
branch
from
eed8258 to
c0cd8be
Compare
This was referenced Jun 24, 2026
Author
|
Superseded: stacked on outdated pr/1-minipc-acpi-hide. RTC/fan fixes will be re-submitted separately after the new minipc hide PR. |
jackadam1981
added a commit
to jackadam1981/coreboot-CXI4
that referenced
this pull request
Jun 28, 2026
Hide laptop/tablet-class ACPI and storage on Acer Chromebox CXI4 (Kaisa) when built as SYSTEM_TYPE_MINIPC. Prior related PRs MrChromebox#36, MrChromebox#37, and MrChromebox#38 were closed. Those were AI-auto submissions without hardware validation. This patch is submitted only after manual flash testing and acceptance on real hardware. Hardware scope: I only have one device (Kaisa / Acer Chromebox CXI4). All testing below is on that single unit. Other Puff SKUs are unchanged at compile time (BOARD_GOOGLE_KAISA* gates only). Kconfig (defaults enable hide; config.kaisa.uefi unchanged): - src/Kconfig: SYSTEM_HIDE_AC_ADAPTER / SYSTEM_HIDE_BATTERY (def_bool y if SYSTEM_TYPE_MINIPC) - src/mainboard/google/puff/Kconfig: KAISA_HIDE_VBTN, KAISA_HIDE_R8168_ACPI, KAISA_HIDE_EMMC, KAISA_HIDE_SATA under BOARD_GOOGLE_KAISA* EC ACPI (compile-time omit or _STA=0; EC Notify guarded): - src/ec/google/chromeec/acpi/ac.asl: omit Device (AC) / ACPI0003 - src/ec/google/chromeec/acpi/battery.asl: omit BAT0/BAT1; guard Notify - src/ec/google/chromeec/acpi/ec.asl: guard Notify(AC/BAT*) on _Qxx - src/ec/google/chromeec/acpi/vbtn.asl: VBTN/VBTO _STA=0 when hide - src/ec/google/chromeec/acpi/superio.asl: keyboard _STA=0 when hide Drivers / SoC / devicetree: - src/drivers/net/r8168.c: skip R8168 SSDT; PCI 10ec:8168 stays up - src/soc/intel/cannonlake/fsp_params.c: SataEnable/ScsEmmcEnabled off - src/soc/intel/cannonlake/acpi/scs.asl: eMMC _STA=0 when hide - src/mainboard/google/puff/variants/kaisa/overridetree.cb: sata off Tested on Kaisa only (single DUT): MrChromebox-2606 baseline vs this ROM (linux_v0.2.0). kaisa-pr1-hide-accept: baseline fail=2 (R8168 ACPI, 8086:02d3 SATA, 8086:02c4 eMMC visible); with this patch fail=0. Signed-off-by: Jack <jackadam1981@users.noreply.github.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depends on #36.
Kaisa / Acer CXI4 16 MiB UEFI baseline: non-ChromeOS FMD with MRC/SPD cache regions, Kaisa thermal/power devicetree tuning, and EC bring-up fixes for chromebox use (RTC, fan policy, AC-loss power state).
Hardware / test platform
BOARD_GOOGLE_KAISA, Puff)debian-build(192.168.2.18), Dockercoreboot/coreboot-sdkChanges
uefi-16MiB.fmdAdds FMD layout for 16 MiB boards with MRC cache and SPD cache regions required for reliable cold boot on non-ChromeOS builds (same pattern as other MrChromebox 16 MiB boards).
Kconfig: defaultFMDFILEtouefi-16MiB.fmdwhenBOARD_ROMSIZE_KB_16384 && !CHROMEOS.Kaisa
overridetree.cbEC / ACPI
EC_GOOGLE_CHROMEEC_RTC� ramstage RTC sync (ec.c); fixes incorrect date/time in UEFI setup and OS after G3.EC_GOOGLE_CHROMEEC_AUTO_FAN_CTRL� expose fan auto control via EC_REG(ACPIec.asl).EC_GOOGLE_CHROMEEC_AFTER_G3_STATE� default power-off after AC loss (POWER_STATE_DEFAULT_ON_AFTER_FAILURE=n) � appropriate for desktop chromebox.RTC
mc146818rtc.c� small fix for EC-backed RTC path on this platform.Validation performed
config.kaisa.uefion CML docker SDK_REGflash-coreboot.sh)Example BIOS version string on DUT (integrated branch):
build-kaisa-minipc-& -dirty(2026-06-24).Known limitations
RtkUndiDxefor RTL8111H) in addition toCONFIG_EDK2_NETWORK_PXE_SUPPORTin configs/cml: expand config.kaisa.uefi for Acer CXI4 Chromebox #38.Files (6)
uefi-16MiB.fmd,puff/Kconfig,kaisa/overridetree.cb,ec.c,ec.asl,mc146818rtc.c.Build / test plan
make defconfig CONFIG_DEFCONFIG=configs/cml/config.kaisa.uefi && make -j$(nproc)mrc_cache,spd_cacheDependencies
CONFIG_EDK2_RTKUNDI_DRIVERin configs/cml: expand config.kaisa.uefi for Acer CXI4 Chromebox #38)