Add optional octave-snap: fold isolated single-note octave spikes onto the melody - #129
Conversation
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Warning Review limit reached
Next review available in: 4 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
A toggleable post-pass (
--octave_snap, GUI "Octave Spike Snap", off by default) that folds isolated single-note octave jumps back onto the melody: the occasional lone note a pitch tracker lifts or drops by an octave while its neighbours stay put — jarring to sing and read.Why conservative — validated, not guessed
I prototyped this against the 8 professional reference songs and measured note range, median octave offset vs the reference, and how many notes moved. Findings that shaped the design:
Because octave is scoring-irrelevant (the ptAKF scorer folds octaves), this never changes the game score — it is purely a display/singability polish.
Scope / honesty
This fixes isolated spikes. It does not fix a whole passage that is consistently an octave off (2 of the 8 songs have that) — that is a deeper pitch-tracking problem (octave continuity on the raw f0), out of scope here and called out in the docs.
Surfaces (kept in sync)
CLI
--octave_snap, GUI toggle in Post-Processing, config default, runner arg, CLI help, README, and tooltip — all documenting that it is conservative, score-neutral, and does not fix whole-section shifts.Tests
7 unit tests (isolated up/down spike folded; genuine leap, small interval, unstable context, wide-range all untouched; pitch class preserved; short-input no-op). Full suite 858 passed / 4 skipped.
Default: off (opt-in) for now — happy to revisit the default per your call.