Initial commit of Vimeo module - #278
Conversation
|
Thanks for including this! Would it be possible to update the npm version of hello.js with these changes? Cheers! |
|
Thanks very much, and thanks for providing such a helpful library! |
|
Sorry to be a pain, but it seems that v1.7.0 hasn't been re-built with the Vimeo module included - there's no reference to |
|
@jimmed sorry about the lack of communication there. I removed it from the list because i didn't think it had the minimum set of required features. Importantly the facade for querying Vimeo needs to have some predefined endpoints. So that it behaves like all other HelloJS modules. These endpoints even if they already match need to be defined, so we can test for their presence. This helps populate the pages like http://adodson.com/hello.js/tests/#hello-x-api-path--method--data--callback-- i.e. Also converts the generic hello js parameter, i.e. Also the response should be formatted to match the expected response. These differ per endpoint, again please see //adodson.com/hello.js/tests/ examples. I hope you'll consider working on this some more to get it ready. It seems like a pretty comprehensive API they have. |
|
btw: in the meantime, you can still include |
|
Unfortunately I'm working in a webpack bundle so including the file directly isn't a particularly pleasant option. I have a functional workaround for now so I'm happy, but I don't think I'll have a large amount of time to commit to fleshing out the rest of the module. Watch this space ⬇️ |
This is the hello.js counterpart to MrSwitch/node-oauth-shim#15