Port to Minecraft 26.1.2 (Fabric)#4
Open
vanlueckn wants to merge 19 commits into
Open
Conversation
Switch all imports and method names from Yarn (World, PlayerEntity, NbtHelper, ItemUsageContext, ActionResult, Text, MutableText, TranslatableTextContent, useOnBlock, appendTooltip, etc.) to Mojang mappings, since Yarn ends with Minecraft 1.21.11. Replace damage(int, LivingEntity, EquipmentSlot) with the vanilla hurtAndBreak(int, ServerLevel, LivingEntity, Consumer<Item>) signature; the ServerLevel cast is guarded by an earlier isClientSide return. Fix the prior ItemGroups field type to CreativeModeTab.
The branch was half-migrated and could not compile. Restore the Item.Properties-accepting Linkingtool / MultiLinkingTool constructors so callers can attach a ResourceKey before construction (mandatory in 26.1.2), swap the removed NbtUtils.writeBlockPos / readBlockPos for IntArrayTag helpers, switch Player.displayClientMessage (gone in 26.1.2) back to sendSystemMessage, and call Level.isClientSide() as the field is private. Mirrors the 26.1.2-neoforge fix; the Fabric build path now uses Mojang mappings, so the same source compiles for both loaders.
ItemStack#hurtAndBreak in 26.1.2 takes ServerPlayer, not Player. The server-side branch is already gated on !isClientSide(), so the cast is safe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hurtAndBreak)eu.gir→com.troblecodingspackage rename from upstream (rename already present in this branch — kept current contents)