Port to Minecraft 26.1.2 (NeoForge)#5
Open
vanlueckn wants to merge 15 commits into
Open
Conversation
multilinkingtool dont work
Replace Forge event bus retrieval (FMLJavaModLoadingContext) with NeoForge's ModLoadingContext.getActiveContainer().getEventBus(), and swap BuildCreativeModeTabContentsEvent to the net.neoforged package.
Replace the removed NeoForge convenience hurtAndBreak(int, LivingEntity, EquipmentSlot) with the vanilla hurtAndBreak(int, ServerLevel, LivingEntity, Consumer<Item>) signature in both Linkingtool and MultiLinkingTool. The ServerLevel cast is safe because both call sites are guarded by an earlier isClientSide return.
The branch was half-migrated and did not compile. Restore the Item.Properties-accepting Linkingtool / MultiLinkingTool constructors so callers route registrations through DeferredRegister.Items#registerItem with auto-set ResourceKeys, swap the removed NbtUtils.writeBlockPos / readBlockPos for IntArrayTag helpers on Linkingtool, switch Player.displayClientMessage (gone in 26.1.2) back to sendSystemMessage, and call Level.isClientSide() as the field is private.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eu.gir→com.troblecodingspackage rename from upstream (rename already present in this branch — kept current contents)