Conversation
- Mark `RawImagePatch` weak - Fix reversed condition in disk image unmounting - Ensure source files are closed when copying - Use 0-based indexing when determining installer OS version Bug: None Change-Id: I015f2b0d9c88a5ec128822d55c974e22723a1a6e Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5291963 Reviewed-by: Mark Mentovai <mark@chromium.org>
Recently, Breakpad symbol files have exceeded the various 32-bit limits in these utils and we started seeing integer overflows. This is also fixing a build issue in src/common/mac/dump_syms.cc. Change-Id: Ibd913816c3b2b1171ac9991718c8911ac31eda86 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5299472 Reviewed-by: Ivan Penkov <ivanpe@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Bug: None Change-Id: I7f3709ee7e8b7e9e938850b1bbe24925e3e03c9b Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5300127 Reviewed-by: Mark Mentovai <mark@chromium.org>
Split out from https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5300127/1..4/src/processor/range_map_unittest.cc#b507 Bug: None Change-Id: Iedc8508b6c123a54fdd1de2e2719dcd70adb03a6 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5300128 Reviewed-by: Ivan Penkov <ivanpe@chromium.org>
…er_arm64.cc Also, defining __STDC_FORMAT_MACROS before including <inttypes.h> Change-Id: Ia25c4353412ca70512efef5e98670687ab575750 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5310977 Reviewed-by: Joshua Peraza <jperaza@chromium.org>
After reading minidump context with x86 xstate data, we seek past it, so there needs to be a check to see that the seek operation did not fail. Change-Id: I8ed4394e452c435234116d97fd65856345cb618a Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5324600 Reviewed-by: Mike Frysinger <vapier@chromium.org>
Change CompilationUnit::SkipAttribute() and CompilationUnit::ProcessOffsetBaseAttribute() to print the unknown form types they encounter. Along the way, fix various formatting issues, stray trailing spaces, and update some NULLs to nullptrs. Change-Id: I5b3e72c9c6c9cb31e8a930e54418adb74b02f6c2 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5366242 Reviewed-by: Joshua Peraza <jperaza@chromium.org>
It is undefined behavior to access mis-aligned pointers. Change-Id: I06f676c6a4b92a4bb58db76b8f23750d18148940 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5380937 Reviewed-by: Ivan Penkov <ivanpe@chromium.org>
Change-Id: Ie62795137770cff7cda7494c5527457b1e355897 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5402921 Reviewed-by: Ivan Penkov <ivanpe@chromium.org>
Summary:
Android prefers `.note.gnu-build-id`[0] as BuildId than anyother PT_NOTE
phdrs. This CL tries to read ElfBuildId from `.note.gnu.build-id` first
to fix the BuildId mismatch issue between Android tombstone report and
breakpad symbol file.
e.g
```
Section Headers:
[Nr] Name Type Address Offset
Size EntSize Flags Link Info Align
[ 0] NULL 0000000000000000 00000000
0000000000000000 0000000000000000 0 0 0
[ 1] .note.androi[...] NOTE 0000000000000270 00000270
0000000000000018 0000000000000000 A 0 0 4
[ 2] .note.hwasan[...] NOTE 0000000000000288 00000288
000000000000001c 0000000000000000 A 0 0 4
[ 3] .note.gnu.bu[...] NOTE 00000000000002a4 000002a4
0000000000000020 0000000000000000 A 0 0 4
$ readelf -x .note.hwasan.globals
Hex dump of section '.note.hwasan.globals':
0x00000288 08000000 08000000 03000000 4c4c564d ............LLVM
0x00000298 00000000 98890100 409d0100 ........@...
$ readelf -x .note.gnu.build-id
Hex dump of section '.note.gnu.build-id':
0x000002a4 04000000 10000000 03000000 474e5500 ............GNU.
0x000002b4 a4eb3625 c1db6452 1e881973 bfdff9bd ..6%..dR...s....
```
The BuildId in tombstone:
```
libartbase.so (BuildId: c7e463b51b0898d442269a421353bdbd)
```
But the breakpad dump_syms got:
```
MODULE Linux arm64 000189989D40000100000000000000000 libartbase.so
INFO CODE_ID 98890100409D0100
`````
[0]
https://cs.android.com/android/platform/superproject/main/+/main:system/unwinding/libunwindstack/ElfInterface.cpp;l=423-427;drc=3d19fbcc09b1b44928639b06cd0b88f735cd988d
Change-Id: I01e3514e0e2a1ea163c03093055284448ed4e89c
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5463566
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Change-Id: Ib785633b229d3f17534da9b0de93255e80fddd70 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5484086 Reviewed-by: Joshua Peraza <jperaza@chromium.org>
|
Thanks for your contribution! Unfortunately, we don't use GitHub pull requests to manage code contributions to this repository. Instead, please see README.md which provides full instructions on how to get involved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )